So, question: should we pass -p to login, so env vars like DISPLAY remain available? I don't know if that would cause any security problems or not, or cause any other conflicts.

/cc @lethalman, since you seem to be pretty knowledgeable in this area. (That, and you helped me out with precisely the problem I'm trying to help others avoid.)

That's super awesome and useful! Thank you 🍻
I 👍

I think an alternative to using login -p to preserve DISPLAY would be to add this to environment.extraInit:

export DISPLAY="$(systemctl --user show-environment | ${pkgs.gnused}/bin/sed 's/^DISPLAY=\(.*\)/\1/; t; d')"

(cribbed from nixos/modules/programs/ssh.nix)

... but I'm not sure. I don't have much experience in this particular area, so I'd certainly appreciate it if someone else would chime in. All examples I've seen online use /bin/login instead of /bin/login -p, and even the docs for login suggest -p is specifically "Used by getty(8) to tell login not to destroy the environment." So I'm hesitant to use -p.

I suppose we could just punt on it for now, though. I would think it would be ideal, however, if one wouldn't need to guess at the correct DISPLAY variable.

(triage) status?

@cstrahan is there anything that remains to be done before integrating this?

Should be fine; merging.