helper tool to track XenServer components within nixpkgs #8673
Conversation
| @@ -0,0 +1,54 @@ | |||
| {stdenv, fetchurl, fetchgit, nix-template-rpm }: | |||
|
|
|||
| # Xenserver buildroot of somehow around XenServer 6.5. | |||
There was a problem hiding this comment.
This comment might make a good meta.longDescription.
|
I added some minor comments. I don't have the proper context to review this properly, but I guess it can't hurt to merge it in since it doesn't change any existing stuff. Can you at least confirm you've tested it and it works as expected? |
|
@falsifian, thank you very much for the detailed review! I'll address all the points that you raised. |
|
Thanks. The most important thing: can you confirm you've used this expression and it works? The other points are minor and can be fixed after merging this. |
| # Xenserver is not an application by itself, but just a collection of components. | ||
| # This package only provides the build inputs to actually build the components of xenserver. | ||
| stdenv.mkDerivation rec { | ||
| name = "xenserver-${version}"; |
There was a problem hiding this comment.
Should the name be xenserver-buildroot?
There was a problem hiding this comment.
Thanks, that would be better, yes.
|
@falsifian, thank you very much for your efforts in getting the PR merged. The script works, but part of it depends heavily on the naming of the ocaml modules in PR #8705 and #8672, which is about to change. So once the other two PRs are fixed I would update this PR accordingly before getting it merged. |
|
ping :) |
No description provided.