Installer remembers values if submit fails #2367
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ction if the form submit results in an error.
jobhh
changed the title
jobhh
changed the title
phy25
requested changes
Jan 20, 2020
|
@jobhh could you implement the suggestion? |
Co-authored-by: Henry Pan <github@phy25.com>
|
@Klap-in done |
phy25
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the installer gives an "illegal or empty value" error, it reloads the page. During this it clears the password fields, ticks "Enable ACL" and the anonymous usage data checkboxes. The license is also reset to default when "Do not show any license information" was selected.
This remembers the license regardless of which was selected and remembers the anonymous data collection checkbox. "Enable ACL" is still set to checked every time.