Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added better support for none pure enums in translate-c #975

Merged
merged 1 commit into from May 2, 2018
Merged

Added better support for none pure enums in translate-c #975

merged 1 commit into from May 2, 2018

Conversation

Hejsil
Copy link
Sponsor Contributor

@Hejsil Hejsil commented May 2, 2018

No description provided.

andrewrk
andrewrk approved these changes May 2, 2018
View reviewed changes
Copy link
Member

@andrewrk andrewrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge if tests passed for you locally

@andrewrk
Copy link
Member

andrewrk commented May 2, 2018 •
edited

...compiler-rt-windows-x86_64-ReleaseFast-bare std.atomic.queue... there goes my theory

I ran this test on linux in a loop for 24 hours straight and it was fine. I'll try the same on windows

Anyway that's unrelated to this PR.

@andrewrk andrewrk merged commit 6f002e7 into master May 2, 2018
@andrewrk andrewrk deleted the none-pure-enums branch May 2, 2018 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewrk andrewrk andrewrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hejsil @andrewrk