Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ltrace: fix warnings and bugs using patches from debian #39877

Merged
merged 1 commit into from May 2, 2018
Merged

ltrace: fix warnings and bugs using patches from debian #39877

merged 1 commit into from May 2, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 2, 2018

For details on the patches applied, see:

https://sources.debian.org/patches/ltrace/0.7.3-6/

Disabling '-Werror' may be a problem in the future again,
but for now keep things simple now that they're fixed.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
ltrace: fix warnings and bugs using patches from debian
3ecad27 
For details on the patches applied, see:

https://sources.debian.org/patches/ltrace/0.7.3-6/

Disabling '-Werror' may be a problem in the future again,
but for now keep things simple now that they're fixed.
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: ltrace

Partial log (click to expand)

make[2]: Leaving directory '/build/ltrace-0.7.3/testsuite'
make[1]: Leaving directory '/build/ltrace-0.7.3/testsuite'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3
shrinking /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3/bin/ltrace
gzipping man pages under /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3/bin
patching script interpreter paths in /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3
checking for references to /build in /nix/store/g3c041iwm2qr4rsirf6kgglg0f0kmwbr-ltrace-0.7.3...

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ltrace

Partial log (click to expand)

/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/bash: line 17: cd: aarch64: No such file or directory
make[3]: *** [Makefile:382: all-recursive] Error 1
make[3]: Leaving directory '/build/ltrace-0.7.3/sysdeps/linux-gnu'
make[2]: *** [Makefile:299: all-recursive] Error 1
make[2]: Leaving directory '/build/ltrace-0.7.3/sysdeps'
make[1]: *** [Makefile:741: all-recursive] Error 1
make[1]: Leaving directory '/build/ltrace-0.7.3'
make: *** [Makefile:447: all] Error 2
builder for '/nix/store/wrq6365r2ql9i29gyhzh18w3vrxda6cm-ltrace-0.7.3.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/wrq6365r2ql9i29gyhzh18w3vrxda6cm-ltrace-0.7.3.drv' failed

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: ltrace

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@dtzWill
Copy link
Member Author

dtzWill commented May 2, 2018

For the curious, looks like aarch64 build already failed.

As future work someone might want to look through ubuntu's patches[1] which apparently fix on aarch64 and some other things.

[1] https://bazaar.launchpad.net/~ubuntu-branches/ubuntu/trusty/ltrace/trusty/files/head:/debian/patches/

@dtzWill dtzWill merged commit 519d19b into NixOS:master May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dtzWill @GrahamcOfBorg