[zen] again: Font Awesome update to v4.7.0 + theme fork with Fork Awesome v1.0.11 #152
Conversation
|
Comprehension question before I mess things up: |
|
Yes, ignore |
v7/zen-jinja/conf.py.sample
Outdated
| ('https://getnikola.com', 'About me', 'icon-user'), | ||
| ('https://twitter.com/getnikola', 'My Twitter', 'icon-twitter'), | ||
| ('https://github.com/getnikola', 'My Github', 'icon-github'), | ||
| ('/index.html', 'Home', 'fa-home'), |
There was a problem hiding this comment.
You need the fa prefix as well (eg. fa fa-home).
There was a problem hiding this comment.
I'd prefer to add the prefix to the arusahni_helper.tmpl to avoid adding it to every navigation item:
<%def name="html_navigation_links()">
[...]
<li><a href="${url}" title="${text}"><i class="fa ${icon} fa-3x"></i></a></li>
[...]Is this a valid option?
There was a problem hiding this comment.
That can work too, although (a) why fa-3x if we don’t need it now? (b) that wouldn’t cut it for font awesome v5 if someone wanted to use it
There was a problem hiding this comment.
a) an attempt of making use of an existing class element (fa-Xx sizes) instead of 'font-size' declaration in the css...(you started with getting rid of cruft ;))
b) thanks for clarification, I haven't gone in for FA5.
There was a problem hiding this comment.
Setting font-size in CSS is more flexible than static .fa-2x/3x sizing.
…, correct icon use in conf.py.sample
|
Changes:
From my perspective I'm done now...(?) |
Signed-off-by: Chris Warrick <kwpolska@gmail.com>
|
Merged, thanks! On a side note, the |
|
I upgraded |
Hey all,
as proposed in #151 I updated the
zenfamily to FA4 (de9189c) and created a variant (zen-forkawesome) that uses Fork Awesome icon fonts (2433919).Before messing things up I decided to accomplish that in a new branch so my last PR was closed when deleting the former working branch.