Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/kafka: fix and refactor tests #40390

Merged
merged 1 commit into from May 12, 2018
Merged

nixos/tests/kafka: fix and refactor tests #40390

merged 1 commit into from May 12, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 12, 2018 •
edited

Motivation for this change

The tests for Apache Kafka 0.9, 0.10, 0.11, and 1.0 always failed for i686-linux and sometimes failed for x86_64-linux on Hydra.

  • Refactor into single file for all versions
  • Improve timing, prevent non-deterministic failures
  • Fix tests for i686-linux

@xeji
nixos/tests/kafka: fix and refactor tests
13f83ba 
- refactor into single file for all versions
- improve timing, prevent non-deterministic failures
- fix tests for i686-linux
@xeji xeji mentioned this pull request May 12, 2018
Closed
41 tasks
@xeji
Copy link
Contributor Author

xeji commented May 12, 2018

@GrahamcOfBorg test kafka.kafka_1_0

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.kafka.kafka_1_0

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.kafka.kafka_1_0

Partial log (click to expand)

kafka: exit status 0
zookeeper1: running command: sync
zookeeper1: exit status 0
test script finished in 106.16s
cleaning up
killing kafka (pid 593)
killing zookeeper1 (pid 605)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/qvxsjyrmj9h38hsn5771jv05s7ipybfg-vm-test-run-kafka_1_0

@xeji
Copy link
Contributor Author

xeji commented May 12, 2018

cc @NeQuissimus

@NeQuissimus NeQuissimus merged commit 92cf881 into NixOS:master May 12, 2018
@NeQuissimus
Copy link
Member

thank you

@xeji xeji deleted the kafka branch May 12, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeQuissimus NeQuissimus NeQuissimus approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xeji @GrahamcOfBorg @NeQuissimus