Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

virtmanager: add missing virt-install runtime dependencies #40380

Merged
merged 1 commit into from May 13, 2018
Merged

virtmanager: add missing virt-install runtime dependencies #40380

merged 1 commit into from May 13, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 11, 2018

Motivation for this change

Fix #40177 . virt-install calls some utility programs directly from initrdinject.py that were missing on PATH unless manually installed. Add these missing dependencies to PATH in the wrapper.

Please backport to 18.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
virtmanager: add missing virt-install runtime deps
6a2d707 
virt-install calls some programs from initrdinject.py
that were missing on PATH
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtmanager

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: virtmanager

Partial log (click to expand)

   Compiling rustc_const_math v0.0.0 (file:///build/rustc-1.25.0-src/src/librustc_const_math)
   Compiling syntax_ext v0.0.0 (file:///build/rustc-1.25.0-src/src/libsyntax_ext)
building of '/nix/store/6bhb5q083wm9wqgfmhfik4x99nmrmmwp-rustc-1.25.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/v6ibjn8kg7xbj3ayhf08caqk13wnwj39-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jrj3zpcll20xh7ymlfqlyjyhjj9xwzr1-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/axb6rhl75fi4aafvyvkl5wavhwhl4ypr-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/x28y9swfsgq008518a0mrwp50fqrcgfn-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/1r2zqznx9dm9nj2yr018www7jn3prdn5-adwaita-icon-theme-3.28.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/45d8w7wln74lzjbm6jlfnfzh4g8g0vw5-virt-manager-1.5.1.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/45d8w7wln74lzjbm6jlfnfzh4g8g0vw5-virt-manager-1.5.1.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: virtmanager

Partial log (click to expand)

test [run-pass] run-pass/wf-bound-region-in-object-type.rs ... ok
test [run-pass] run-pass/where-clause-bounds-inconsistency.rs ... ok
building of '/nix/store/p5lc7m572zh0bxyn3yzyq1i285db5q6m-rustc-1.25.0.drv' timed out after 4000 seconds
cannot build derivation '/nix/store/5z491rwbhvkhvzqd05y8386ivrgdwhw3-cargo-0.26.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/47hnj48iky24gln4kaz783y017pvxj0d-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/c2gkx7n4i96k1pwi631kmiam9vqig627-hook.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/licp5248pmycz535d0y1ijvg5az8fj06-icon-naming-utils-0.8.90.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/hl53ysdvc5pzlqmf5cp0rnwlp2agbkyk-adwaita-icon-theme-3.28.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/vmanazvxhyizjcavg0riqm7w4y5zrqif-virt-manager-1.5.1.drv': 2 dependencies couldn't be built
error: build of '/nix/store/vmanazvxhyizjcavg0riqm7w4y5zrqif-virt-manager-1.5.1.drv' failed

@xeji
Copy link
Contributor Author

xeji commented May 13, 2018

@GrahamcOfBorg build virtmanager

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: virtmanager

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: virtmanager

Partial log (click to expand)

/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/share/virt-manager/virt-clone: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python2"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/share/virt-manager/virt-xml: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python2"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/share/virt-manager/virt-manager: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python2"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/share/virt-manager/virt-install: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/l9j2jsc9flrbmpf799nw9wdq59gpwms8-python-2.7.14/bin/python2"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/bin/.virt-convert-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/bin/.virt-clone-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/bin/.virt-xml-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/bin/.virt-manager-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
/nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1/bin/.virt-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/2b9w07ph8arkkb87hbhspziijm4rnr0z-virt-manager-1.5.1...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: virtmanager

Partial log (click to expand)

/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/share/virt-manager/virt-install: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/ydxpyrgfqj6z7lqnv059566l7kpn35j3-python-2.7.14/bin/python2"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/share/virt-manager/virt-manager: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/ydxpyrgfqj6z7lqnv059566l7kpn35j3-python-2.7.14/bin/python2"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/share/virt-manager/virt-xml: interpreter directive changed from "/usr/bin/env python2" to "/nix/store/ydxpyrgfqj6z7lqnv059566l7kpn35j3-python-2.7.14/bin/python2"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/bin/.virt-xml-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/bin/.virt-manager-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/bin/.virt-install-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/bin/.virt-convert-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1/bin/.virt-clone-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/a4qslf0yfs44mhnbagarn232sjnckhy0-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1...
/nix/store/agxr64vpg5596k6shsmznaywbx350ymv-virt-manager-1.5.1

@xeji xeji merged commit 66d2041 into NixOS:master May 13, 2018
@xeji xeji deleted the fix-virt-install branch May 13, 2018 17:59
xeji added a commit that referenced this pull request May 13, 2018
@xeji
virtmanager: add missing virt-install runtime deps (#40380)
4534986 
virt-install calls some programs from initrdinject.py
that were missing on PATH

(cherry picked from commit 66d2041)
@xeji
Copy link
Contributor Author

xeji commented May 13, 2018

backported in 4534986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg