Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/mesos: fix non-deterministic service and test failure #40373

Merged
merged 2 commits into from
May 13, 2018
Merged

nixos/mesos: fix non-deterministic service and test failure #40373

merged 2 commits into from
May 13, 2018
+4 −2

Conversation

xeji
Copy link
Contributor

@xeji xeji commented May 11, 2018

Motivation for this change

nixos/tests/mesos failed most of the time on Hydra. This was caused by two different issues:

  1. mesos-slave.service failed if docker.service wasn't ready due to a missing After= dependency.
  2. The nixos test didn't wait for all relevant services and ports to be available before sending requests.

xeji added 2 commits May 11, 2018 19:26
@xeji
nixos/tests/mesos: wait for all services and ports
0d2a4ed 
to be available before sending requests.
Avoids non-deterministic test failure.
@xeji
nixos/mesos-slave: start after docker
ec00b6f 
If docker is enabled, start mesos-slave.service after docker.service
to avoid a race condition that could result in mesos-slave to fail
with "Failed to create docker: Timed out getting docker version"
@xeji xeji mentioned this pull request May 11, 2018
Closed
41 tasks
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 11, 2018
@xeji
Copy link
Contributor Author

xeji commented May 11, 2018

@GrahamcOfBorg test mesos

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.mesos

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: tests.mesos

Partial log (click to expand)

slave: exit status 0
master: running command: sync
master: exit status 0
test script finished in 33.51s
cleaning up
killing slave (pid 593)
killing master (pid 605)
vde_switch: EOF on stdin, cleaning up and exiting
vde_switch: Could not remove ctl dir '/build/vde1.ctl': Directory not empty
/nix/store/qx6a946nmdqs95kvw0b6px09ir7977sn-vm-test-run-mesos

@xeji xeji merged commit c482b41 into NixOS:master May 13, 2018
@xeji xeji deleted the fix-mesos-test branch May 13, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xeji @GrahamcOfBorg