Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.sasmodels: fix build #40381

Merged
merged 1 commit into from May 12, 2018
Merged

pythonPackages.sasmodels: fix build #40381

merged 1 commit into from May 12, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 11, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from FRidh as a code owner May 11, 2018 20:55
@Ma27
Copy link
Member Author

Ma27 commented May 11, 2018 •
edited

currently running nox-review...

@xeji
Copy link
Contributor

xeji commented May 11, 2018 •
edited

If the hash changed for the same version it might be better to pin it to a git revision.

@dotlambda
Copy link
Member

And fetchFromGitHub should be used instead.

@Ma27
pythonPackages.sasmodels: fix build
89b3512 
* The revision checksum changed, so it's safer to pin the package
  against an explicit `git` tag (NixOS#40381 (comment))

* Repaired `checkPhase` to run `py.test` properly on Python {2,3}

* Bumped to latest revision (unstable-2018-04-27) as it supports the entire test suite
  properly.
@Ma27
Copy link
Member Author

Ma27 commented May 12, 2018

@dotlambda @xeji thanks a lot for your feedback! I applied it and performed a bump to the latest revision (for now) as it provides proper configuration for the py.test suite (have a look at SasView/sasmodels@a69d8cd and the following commits for further reference)

@xeji
Copy link
Contributor

xeji commented May 12, 2018

@GrahamcOfBorg build python36Packages.sasmodels python27Packages.sasmodels sasview

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python36Packages.sasmodels, python27Packages.sasmodels, sasview

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: python36Packages.sasmodels, python27Packages.sasmodels, sasview

Partial log (click to expand)

sasmodels/exception.py .                                                 [ 46%]
sasmodels/generate.py .                                                  [ 47%]
sasmodels/model_test.py ................................................ [ 72%]
............................                                             [ 87%]
sasmodels/resolution.py ...ssss.....s..                                  [ 95%]
sasmodels/rst2html.py .                                                  [ 96%]
sasmodels/sasview_model.py .......                                       [100%]

==================== 183 passed, 5 skipped in 29.99 seconds ====================
error: build of '/nix/store/lri75g9yi91vz3kqggbwdsapvhp80hjm-sasview-4.1.2.drv' failed

@xeji
Copy link
Contributor

xeji commented May 12, 2018

@Ma27 can you have a look at the sasview failure?

@Ma27
Copy link
Member Author

Ma27 commented May 12, 2018

sasview fails locally with the following message:

fixed-output derivation produced path '/nix/store/5dh1mdj027ad8sprk12fqa5h5bpdxs5n-sasview' with sha256 hash '12k1w4yq1mzjxcp2cqb562c7cbwzhi54rsbmgi0fax0i1660q167' instead of the expected hash '05la54wwzzlkhmj8vkr0bvzagyib6z6mgwqbddzjs5y1wd48vpcx'

Seems as all of their hashes changed, will fix sasview as well...

@Ma27
Copy link
Member Author

Ma27 commented May 12, 2018

interesting... I just pinned sasview against the release's revision (SasView/sasview@d908932) and it breaks the test suite locally.

I'm currently working on a fix, however I'm not sure what to think of that. At least in case of any further breakage we should perform some deeper investigation to see what happens in their release process.

Pinging @rprospero as he packaged the software two months ago - do you know anything about the recent issues?

@Ma27 Ma27 changed the title pythonPackages.sasmodels: fix hash pythonPackages.sasmodels: fix build May 12, 2018
@xeji
Copy link
Contributor

xeji commented May 12, 2018

If you like we could merge this anyway since pythonPackages.sasmodels builds fine, and fix sasview in a separate PR. Your choice...

@Ma27
Copy link
Member Author

Ma27 commented May 12, 2018

@xeji you're absolutely right, let's merge this PR for now, fixing sasview is basically out of scope :-)

@xeji
Copy link
Contributor

xeji commented May 12, 2018

just wanna see sasmodels builds from ofborg first

@GrahamcOfBorg build python36Packages.sasmodels python27Packages.sasmodels

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python36Packages.sasmodels, python27Packages.sasmodels

Partial log (click to expand)

/nix/store/qlrkqzis8ph1jfsp9v1k8v0d7zcgsqr3-python3.6-sasmodels-unstable-2018-04-27
/nix/store/xpnkjswiq32h3rq3b3qyq1l6ibnmx0ff-python2.7-sasmodels-unstable-2018-04-27

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: python36Packages.sasmodels, python27Packages.sasmodels

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python36Packages.sasmodels, python27Packages.sasmodels

Partial log (click to expand)

sasmodels/sasview_model.py .......                                       [100%]

==================== 183 passed, 5 skipped in 34.83 seconds ====================
sasmodels/resolution.py ...ssss.....s..                                  [ 95%]
sasmodels/rst2html.py .                                                  [ 96%]
sasmodels/sasview_model.py .......                                       [100%]

==================== 183 passed, 5 skipped in 32.35 seconds ====================
/nix/store/fpw7jrq9bmn3zkq9hm3x6h42q3hcpm0h-python3.6-sasmodels-unstable-2018-04-27
/nix/store/q10hqxyhiflkcjj61c1pfpc96l92zdf6-python2.7-sasmodels-unstable-2018-04-27

@xeji xeji merged commit ea8a62a into NixOS:master May 12, 2018
@Ma27 Ma27 deleted the fix-sasmodels branch May 12, 2018 21:17
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: python36Packages.sasmodels, python27Packages.sasmodels, sasview

Partial log (click to expand)

=== C/C++ compiler error output: ===
khavkine1.cpp: In function ‘PyObject* __pyx_f_9khavkine1___pyx_unpickle_T__set_state(__pyx_obj_9khavkine1_T*, PyObject*)’:
khavkine1.cpp:1916:7: warning: ‘__pyx_t_2’ may be used uninitialized in this function [-Wmaybe-uninitialized]
   int __pyx_t_2[1];
       ^~~~~~~~~
==============================
building of '/nix/store/57yvs2z6ji0i3j7hmap49l1irn9kfc79-python2.7-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/q71h6yqffh2a9pl7ifsf21yhcn6h1dqp-python2.7-h5py-2.7.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/lqy881qqymx314wq3qfckk3lydvycfph-sasview-4.1.2.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/lqy881qqymx314wq3qfckk3lydvycfph-sasview-4.1.2.drv' failed

@rprospero
Copy link
Contributor

I'll try and figure out what's going on with sasview this week.

@Ma27 Ma27 mentioned this pull request May 13, 2018
Merged
8 tasks
Ma27 added a commit to Ma27/nixpkgs that referenced this pull request May 13, 2018
@Ma27
sasview: fix build
856ab17 
The package breaks currently breaks with the following message:

```
fixed-output derivation produced path '/nix/store/5dh1mdj027ad8sprk12fqa5h5bpdxs5n-sasview' with sha256 hash '12k1w4yq1mzjxcp2cqb562c7cbwzhi54rsbmgi0fax0i1660q167' instead of the expected hash '05la54wwzzlkhmj8vkr0bvzagyib6z6mgwqbddzjs5y1wd48vpcx'
```

To fix the build the following changes were applied:

* Switched to latest master for now as the older releases have a broken
  `py.test` configuration and altering hashes.

* Added `checkPhase` which invokes `py.test` directly and drops
  duplicated files from `dist/tmpbuild`.

* Rebased the patches `pyparsing-fix.patch` and `local_config.patch` for
  the latest master revision.

Additionally refer to the discussion in NixOS#40381 for further reference.
xeji pushed a commit that referenced this pull request May 13, 2018
@Ma27 @xeji
sasview: fix build (#40433)
be53a0f 
The package breaks currently breaks with the following message:

```
fixed-output derivation produced path '/nix/store/5dh1mdj027ad8sprk12fqa5h5bpdxs5n-sasview' with sha256 hash '12k1w4yq1mzjxcp2cqb562c7cbwzhi54rsbmgi0fax0i1660q167' instead of the expected hash '05la54wwzzlkhmj8vkr0bvzagyib6z6mgwqbddzjs5y1wd48vpcx'
```

To fix the build the following changes were applied:

* Switched to latest master for now as the older releases have a broken
  `py.test` configuration and altering hashes.

* Added `checkPhase` which invokes `py.test` directly and drops
  duplicated files from `dist/tmpbuild`.

* Rebased the patches `pyparsing-fix.patch` and `local_config.patch` for
  the latest master revision.

Additionally refer to the discussion in #40381 for further reference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @xeji @dotlambda @GrahamcOfBorg @rprospero