Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all references to absent nixos-prepare-root #40723

Merged
merged 1 commit into from May 18, 2018
Merged

Remove all references to absent nixos-prepare-root #40723

merged 1 commit into from May 18, 2018

Conversation

antifob
Copy link
Contributor

@antifob antifob commented May 18, 2018

Fixes the broken 0f5d597 commit.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@antifob
Copy link
Contributor Author

antifob commented May 18, 2018

Also, the referenced commit states that this is no longer necessary due to nix 2.0's magic.
What is this magic? @edolstra

@edolstra edolstra merged commit e86be69 into NixOS:master May 18, 2018
@edolstra
Copy link
Member

The "magic" is that Nix 2.0 has chroot support, so it's no longer needed to bootstrap the target environment by copying Nix to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antifob @edolstra @GrahamcOfBorg @Janik-Haag