Add release counts for labels #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
May 18, 2018
sir/schema/__init__.py
Outdated
| @@ -238,6 +238,7 @@ | |||
|
|
|||
| F("code", "label_code"), | |||
| F("comment", "comment"), | |||
| F("releases", "releases.id", transformfunc=len, trigger=False), | |||
There was a problem hiding this comment.
Is that basically getting the entire set of results from the database server and just calling len() on it? If so, would it be possible to just add support for using count(*) in the query, or does it need the actual rows for some other purpose?
There was a problem hiding this comment.
Yup, I was leaving it as a possible improvement since I just wanted to test initially if it was worth it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Solution
Action