Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m-cli: init at 0.2.5 #40724

Merged
merged 1 commit into from May 19, 2018
Merged

m-cli: init at 0.2.5 #40724

merged 1 commit into from May 19, 2018

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented May 18, 2018

Motivation for this change

Package the self-described Swiss Army Knife for macOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented May 18, 2018

/ping @LnL7

xeji
xeji suggested changes May 18, 2018
View reviewed changes
Copy link
Contributor

@xeji xeji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the package to pkgs/top-level/all-packages.nix.

@yurrriq
Copy link
Member Author

yurrriq commented May 19, 2018

Thanks, @xeji, I've amended and force pushed.

@LnL7 LnL7 merged commit 41f3ced into NixOS:master May 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji requested changes

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yurrriq @LnL7 @xeji @GrahamcOfBorg