Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chromium: 66.0.3359.139 -> 66.0.3359.181 #40718

Merged
merged 2 commits into from May 19, 2018
Merged

chromium: 66.0.3359.139 -> 66.0.3359.181 #40718

merged 2 commits into from May 19, 2018

Conversation

YorikSar
Copy link
Contributor

Motivation for this change

Already landed on master, need to backport to stable as it contains several security fixes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar
chromium: 66.0.3359.139 -> 66.0.3359.170
c6a5b16 
Update includes 4 security fixes, including one critical (see [0]):

* [835887] Critical: Chain leading to sandbox escape. Reported by Anonymous on 2018-04-23:
* [836858] High CVE-2018-6121: Privilege Escalation in extensions.
* [836141] High CVE-2018-6122: Type confusion in V8.
* [$5000][833721] High CVE-2018-6120: Heap buffer overflow in PDFium.  Reported by Zhou Aiting(@zhouat1) of Qihoo 360 Vulcan Team on 2018-04-17

[0] https://chromereleases.googleblog.com/2018/05/stable-channel-update-for-desktop.html

PS: Didn't build Beta and Dev, verified only Stable for now

cc @bendlas @aszlig

(cherry picked from commit 1837026)
@YorikSar
chromium: 66.0.3359.170 -> 66.0.3359.181
fcea258 
(cherry picked from commit 2729875)
@YorikSar
Copy link
Contributor Author

CC @bendlas @vcunat @matthewbauer

@vcunat
Copy link
Member

vcunat commented May 19, 2018

I'm building the default version locally to test a little.

@YorikSar
Copy link
Contributor Author

FYI I've built it on VM, copied and ran locally on my 18.03, it opened several sites just fine. Didn't test it further though.

vcunat
vcunat approved these changes May 19, 2018
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Briefly used, seems OK.

@vcunat vcunat merged commit fcea258 into NixOS:release-18.03 May 19, 2018
vcunat added a commit that referenced this pull request May 19, 2018
@vcunat
Merge #40718: chromium: 66.0.3359.139 -> 66.0.3359.181
6d9aa78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorikSar @vcunat @GrahamcOfBorg