Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xbps: init at 0.52 #40730

Merged
merged 2 commits into from
May 18, 2018
Merged

xbps: init at 0.52 #40730

merged 2 commits into from
May 18, 2018
+66 −0

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented May 18, 2018

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels May 18, 2018
@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: xbps

Partial log (click to expand)

portableproplib/prop_object.c:877:6: error: implicit declaration of function 'fdatasync' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        if (fdatasync(fd) == -1)
            ^
1 error generated.
make[1]: *** [Makefile:67: portableproplib/prop_object.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/private/tmp/nix-build-xbps-0.52.drv-0/source/lib'
make: *** [Makefile:15: all] Error 1
builder for '/nix/store/5apndpw2j0jn0ani33s9r1cfk4qgs101-xbps-0.52.drv' failed with exit code 2
error: build of '/nix/store/5apndpw2j0jn0ani33s9r1cfk4qgs101-xbps-0.52.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xbps

Partial log (click to expand)

shrinking /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin/xbps-uhelper
shrinking /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin/xbps-checkvers
shrinking /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin/xbps-fbulk
shrinking /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin/xbps-uchroot
shrinking /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin/xbps-uunshare
gzipping man pages under /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/lib  /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52/bin
patching script interpreter paths in /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52
checking for references to /build in /nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xbps

Partial log (click to expand)

shrinking /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/bin/xbps-dgraph
shrinking /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/bin/xbps-create
shrinking /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/bin/xbps-alternatives
shrinking /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/lib/libxbps.so.2.0.0
gzipping man pages under /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/lib  /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52/bin
patching script interpreter paths in /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52
checking for references to /build in /nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52...
/nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52

@xeji
Copy link
Contributor

xeji commented May 18, 2018

Darwin build seems to require a -Wno-error=...

@dtzWill
Copy link
Member Author

dtzWill commented May 18, 2018

Darwin build seems to require a -Wno-error=...

Hmm, googling around turned up various things suggesting that fdatasync is not actually supported (which is why it's not declared) but it does exist as a symbol in libSystem?

So my idea was to avoid it on Darwin regardless of what the configure check reports (perhaps the check needs -Werror or something?)....

Does that sound good to you?

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: xbps

Partial log (click to expand)

package_unpack.c:425:8: error: implicit declaration of function 'utimensat' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                        if (utimensat(AT_FDCWD, entry_pname, ts,
                            ^
5 errors generated.
make[1]: *** [Makefile:72: package_unpack.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/private/tmp/nix-build-xbps-0.52.drv-0/source/lib'
make: *** [Makefile:15: all] Error 1
builder for '/nix/store/g2zhz73c1dslrpgnh9lmgwsrin9qzm55-xbps-0.52.drv' failed with exit code 2
error: build of '/nix/store/g2zhz73c1dslrpgnh9lmgwsrin9qzm55-xbps-0.52.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xbps

Partial log (click to expand)

shrinking /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin/xbps-uhelper
shrinking /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin/xbps-checkvers
shrinking /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin/xbps-fbulk
shrinking /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin/xbps-uchroot
shrinking /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin/xbps-uunshare
gzipping man pages under /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/lib  /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52/bin
patching script interpreter paths in /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52
checking for references to /build in /nix/store/80xm16jcm4chavd91z4515gdwb90slc7-xbps-0.52...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xbps

Partial log (click to expand)

shrinking /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/bin/xbps-dgraph
shrinking /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/bin/xbps-create
shrinking /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/bin/xbps-alternatives
shrinking /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/lib/libxbps.so.2.0.0
gzipping man pages under /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/share/man/
strip is /nix/store/jk6j4lh9v5mvjdbdc35sj0zffhhf6s56-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/lib  /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52/bin
patching script interpreter paths in /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52
checking for references to /build in /nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52...
/nix/store/i90anmxyaw84pz97d2gdsgw7sha4nsb0-xbps-0.52

@xeji
Copy link
Contributor

xeji commented May 18, 2018

I found similar comments - but of course nothing official by Apple.
Your fix looks good - better not use fdatasync at all.

@xeji
Copy link
Contributor

xeji commented May 18, 2018

Google sez utimensat doesn't exist on Darwin either...

@dtzWill
Copy link
Member Author

dtzWill commented May 18, 2018

Okay, great.

Unfortunately maybe disabling -Werror is needed regardless?

FWIW others seem to do this, but I was inclined to wait until we had problems to do so ourselves...

I have no idea if xbps is "supposed" to work on Darwin at all anyway, hmm...

@xeji
Copy link
Contributor

xeji commented May 18, 2018

Well, if -Werror gets it to build , why no let people try it. Should crash pretty soon if there's a missing system call.

@dtzWill
xbps: limit to platforms.linux

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
a9d3d4d 
Darwin is a no-go at least:
NixOS#40730 (comment)
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: xbps

Partial log (click to expand)

/nix/store/7qwb7cfzbhbl6fg4lkja06lazjncqpxg-xbps-0.52

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: xbps

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: xbps

Partial log (click to expand)

/nix/store/r1wsgjycdda2l1qrsrjk8igina8j6ag7-xbps-0.52

@dtzWill
Copy link
Member Author

dtzWill commented May 18, 2018

Woo, finally xD. Thanks @xeji .

@dtzWill dtzWill merged commit 61fd8d6 into NixOS:master May 18, 2018
@dtzWill dtzWill deleted the feature/xbps branch May 18, 2018 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @xeji