Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

astroid: 0.10.2 -> 0.11.1 #40720

Merged
merged 1 commit into from May 18, 2018
Merged

astroid: 0.10.2 -> 0.11.1 #40720

merged 1 commit into from May 18, 2018

Conversation

tkerber
Copy link
Member

@tkerber tkerber commented May 18, 2018

Motivation for this change

Version bump.
glib-networking dependancy added to fix image requests via TLS.
Build system changed to cmake.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@xeji
Copy link
Contributor

xeji commented May 18, 2018

@GrahamcOfBorg build astroid

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: astroid

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "webkitgtk-2.4.11"
       ];
     }

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: astroid

Partial log (click to expand)

~/.config/nixpkgs/config.nix, like so:

     {
       permittedInsecurePackages = [
         "webkitgtk-2.4.11"
       ];
     }

xeji
xeji suggested changes May 18, 2018
View reviewed changes
pkgs/applications/networking/mailreaders/astroid/default.nix
@@ -1,24 +1,22 @@
{ stdenv, fetchFromGitHub, scons, pkgconfig, gnome3, gmime3, webkitgtk24x-gtk3
, libsass, notmuch, boost, wrapGAppsHook }:
{ stdenv, fetchFromGitHub, cmake, pkgconfig, gnome3, gmime3, webkitgtk24x-gtk3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webkitgtk24x-gtk3 (2.4.11) is marked as insecure because of several vulnerabilities and should not be used unless really necessary. Please try to change the dependency to webkitgtk (which is 2.20).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an ongoing upstream issue, and as of yet hasn't been fixed. WebKit-GTK 2.4.11 and 2.20 have an incompatible API, so it is non-trivial to fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, so let's merge this anyway.

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: astroid

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@xeji xeji merged commit 2921c44 into NixOS:master May 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xeji xeji xeji approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tkerber @xeji @GrahamcOfBorg @Janik-Haag