Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inkscape: disable parallelBuilding to avoid non-deterministic failure #40717

Merged
merged 1 commit into from May 18, 2018
Merged

inkscape: disable parallelBuilding to avoid non-deterministic failure #40717

merged 1 commit into from May 18, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented May 18, 2018

Motivation for this change

Try to avoid non-deterministic build failure with make, until #40046 is fixed and we can switch back to cmake. Inkscape is currently holding back nixos-unstable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning
inkscape: disable parallelBuilding
05a6e94 
Try to avoid non-deterministic build failure.
@xeji
Copy link
Contributor

xeji commented May 18, 2018

@GrahamcOfBorg build inkscape

@orivej
Copy link
Contributor

orivej commented May 18, 2018

Alternatively you may just delete the enableParallelBuilding line, since it is automatically enabled by cmake, and not enabled with plain make.

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: inkscape

Partial log (click to expand)

            ^
1 warning generated.
  CXX      ui/widget/clipmaskicon.o
  CXX      ui/widget/highlight-picker.o
  CXX      ui/widget/layertypeicon.o
  CXX      ui/widget/insertordericon.o
  CXX      ui/widget/addtoicon.o
  CXX      trace/trace.o
building of '/nix/store/bnb8lnkhb505pw2alim7d2piyxqlbnkb-inkscape-0.92.3.drv' timed out after 1800 seconds
error: build of '/nix/store/bnb8lnkhb505pw2alim7d2piyxqlbnkb-inkscape-0.92.3.drv' failed

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: inkscape

Partial log (click to expand)

gzipping man pages under /nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/bin
patching script interpreter paths in /nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3
/nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/share/inkscape/extensions/voronoi.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/87ak8lm3vzc476vv8ljia13yczwp13mz-python-2.7.14-env/bin/python"
/nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/share/inkscape/extensions/voronoi2svg.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/87ak8lm3vzc476vv8ljia13yczwp13mz-python-2.7.14-env/bin/python"
/nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/share/inkscape/extensions/ungroup_deep.py: interpreter directive changed from "/usr/bin/env python" to "/nix/store/87ak8lm3vzc476vv8ljia13yczwp13mz-python-2.7.14-env/bin/python"
/nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3/share/inkscape/extensions/dpiswitcher.py: interpreter directive changed from "/usr/bin/env python " to "/nix/store/87ak8lm3vzc476vv8ljia13yczwp13mz-python-2.7.14-env/bin/python"
checking for references to /build in /nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3...
/nix/store/1r3fvgp4sybmcibzqvahsk3g0aaxwk6c-inkscape-0.92.3

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: inkscape

Partial log (click to expand)

  CXX      sp-conn-end.o
  CXX      sp-conn-end-pair.o
  CXX      sp-cursor.o
  CXX      sp-defs.o
  CXX      sp-desc.o
  CXX      sp-ellipse.o
  CXX      sp-factory.o
  CXX      sp-filter.o
building of '/nix/store/i27ss0gn3h9jmhapxk5676jpqk8whl8z-inkscape-0.92.3.drv' timed out after 3600 seconds
�[31;1merror:�[0m build of '/nix/store/i27ss0gn3h9jmhapxk5676jpqk8whl8z-inkscape-0.92.3.drv' failed

@matthewbauer
Copy link
Member

Thanks!

@matthewbauer matthewbauer merged commit 18e1aea into NixOS:master May 18, 2018
@hedning hedning mentioned this pull request May 18, 2018
Closed
@vcunat
Copy link
Member

vcunat commented May 19, 2018

I think it's better to keep the = false; line with comment (like this PR does), as accidental addition elsewhere in the attrset will be caught.

@hedning hedning deleted the fix-inkscape-build branch March 1, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@hedning @xeji @orivej @GrahamcOfBorg @matthewbauer @vcunat