Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox, firefox-bin: 60.0 -> 60.0.1, firefox-esr: 60.0esr -> 60.0.1esr #40728

Merged
merged 3 commits into from May 23, 2018
Merged

firefox, firefox-bin: 60.0 -> 60.0.1, firefox-esr: 60.0esr -> 60.0.1esr #40728

merged 3 commits into from May 23, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented May 18, 2018

Motivation for this change

Bug fixes.
https://www.mozilla.org/en-US/firefox/60.0.1/releasenotes/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Tested only the binary package.

ESR 52.x is not updated.

@andir
Copy link
Member

andir commented May 18, 2018

Thanks! Looks good so far. I'll try to build it.

Can you also provide a backport for staging-18.03?

@taku0 taku0 changed the title Firefox bin 60.0.1 firefox, firefox-bin: 60.0 -> 60.0.1, firefox-esr: 60.0esr -> 60.0.1esr May 19, 2018
@taku0 taku0 mentioned this pull request May 19, 2018
Merged
8 tasks
@taku0
Copy link
Contributor Author

taku0 commented May 19, 2018

@andir I made a backport for staging-18.03 #40754

@joachifm joachifm merged commit d522478 into NixOS:staging May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@taku0 @andir @joachifm @GrahamcOfBorg