Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: da69dc40f09f
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: f79e0fcf7537
Choose a head ref
  • 2 commits
  • 2 files changed
  • 2 contributors

Commits on May 4, 2018

  1. python3Packages.yowsup: 2.5.2 -> 2.5.7 

    The latest update of `yowsup` (https://github.com/tgalal/yowsup/releases/tag/v2.5.7)
contains the following fixes:

* Updated tokens
* Fixed tgalal/yowsup#1842: Bug in protocol_groups RemoveGroupsNotificationProtocolEntity
* Other minor bug fixes

The `argparse-dependency.patch` required a rebase onto the latest
version of `setup.py` and ensures that `argparse` won't be needed as
extra dependency as our `python3` package ships `argparse` by default.

A short note to Python 2 support:

the actual issue related to Python 2.x support has been resolved
(tgalal/yowsup#2325 (comment)),
however this relies on `six==1.10` which isn't support by `nixpkgs` as
`six` has been bumped to `1.11`. When trying to inject a patched version
of our `six` package based on `six==1.10` you'll run into issues with
duplicated libraries in your closure as further build dependencies
(`pytest` in this case) use the latest `six` version. As Python 2.7 will
die in 2020 (https://pythonclock.org/) and patching around in the
dependencies of `pytest` to get `yowsup` running isn't worth the effort
in my opinion I decided to keep the Python 2.x build disabled for now.
    @Ma27
    Ma27 committed May 4, 2018
    Configuration menu
    Copy the full SHA
    cf50edf View commit details
    Browse the repository at this point in the history

  2. Merge pull request #39926 from Ma27/update-yowsup 

    python3Packages.yowsup: 2.5.2 -> 2.5.7
    @dotlambda
    dotlambda committed May 4, 2018
    Configuration menu
    Copy the full SHA
    f79e0fc View commit details
    Browse the repository at this point in the history