Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virtualbox: fix pci_get_bus_and_slot removed in kernel 4.17 #39989

Merged
merged 1 commit into from May 7, 2018
Merged

virtualbox: fix pci_get_bus_and_slot removed in kernel 4.17 #39989

merged 1 commit into from May 7, 2018

Conversation

megheaiulian
Copy link
Contributor

@megheaiulian megheaiulian commented May 4, 2018

Motivation for this change

pci_get_bus_and_slot function has been removed in kernel 4.17 and virtualbox doesn't build with that kernel.
Patched virtualbox to use pci_get_domain_bus_and_slot if kernel >=4.17.0.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@megheaiulian megheaiulian changed the title virtualbox: fix pci_get_device removed in kernel 4.17 virtualbox: fix pci_get_bus_and_slot removed in kernel 4.17 May 4, 2018
@matthewbauer matthewbauer merged commit 52dac08 into NixOS:master May 7, 2018
@megheaiulian megheaiulian deleted the feature/virtualbox-kernel-4.17-patch branch May 8, 2018 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants