Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubikey-personalization-gui: port to qt5 #39987

Merged
merged 1 commit into from May 5, 2018
Merged

yubikey-personalization-gui: port to qt5 #39987

merged 1 commit into from May 5, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented May 4, 2018 •
edited

Motivation for this change

Uses QT5's qmake hook (http://doc.qt.io/qt-5/qmake-manual.html) to
build yubikey-personalization-gui with a non-90s interface.

See #33248

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
yubikey-personalization-gui: port to qt5
a050280 
Uses QT5's `qmake` hook (http://doc.qt.io/qt-5/qmake-manual.html) to
build `yubikey-personalization-gui` with a non-90s interface.

See NixOS#33248
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: yubikey-personalization-gui

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25
shrinking /nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25/bin/yubikey-personalization-gui
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25/bin
patching script interpreter paths in /nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25
checking for references to /build in /nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25...
postPatchMkspecs
postPatchMkspecs
/nix/store/6i13ahx9za3ag0f3kpkga33wc0rx8632-yubikey-personalization-gui-3.1.25

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: yubikey-personalization-gui

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25
shrinking /nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25/bin/yubikey-personalization-gui
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25/bin
patching script interpreter paths in /nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25
checking for references to /build in /nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25...
postPatchMkspecs
postPatchMkspecs
/nix/store/d0mv6b0jx0wkd32xw8g7j0s7kpnlj9n3-yubikey-personalization-gui-3.1.25

@xeji
Copy link
Contributor

xeji commented May 4, 2018 •
edited

build yubikey-personalization-gui with a non-90s interface.

When I build this PR locally, the gui looks pretty much the same as with qt4.

@Ma27
Copy link
Member Author

Ma27 commented May 5, 2018

the dashboard remains equal, but the tabs have improved:

QT5 Variant

vs

QT4 Variant

@xeji
Copy link
Contributor

xeji commented May 5, 2018

Ah, thanks, missed that.

@xeji xeji merged commit c94a1e6 into NixOS:master May 5, 2018
@Ma27 Ma27 deleted the yubikey-personalization-gui/qt5-port branch May 5, 2018 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Ma27 @GrahamcOfBorg @xeji