Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 45788b45403e
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 4c8c314689c3
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on May 4, 2018

  1. shutter: wrap XDG_DATA_DIRS with hicolor-icon-theme 

    When opening `shutter` it adds an indicator icon to the status bar.
However this doesn't happen (and an ugly default icon will be used) if
`shutter` can't find the `hicolor-icon-theme`. In such a case a warning
like this can be found in `stderr`:

```
Gtk-WARNING **: Could not find the icon 'image-png'. The 'hicolor' theme
was not found either, perhaps you need to install it.
```

As I don't think that we should force users to install this theme
globally and several other packages including `tor-browser`, `gparted`
or `clawsmail` add `hicolor-icon-theme` to their closure this seems to
be a fair measure.
    @Ma27
    Ma27 committed May 4, 2018
    Configuration menu
    Copy the full SHA
    40226e6 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #39913 from Ma27/shutter/add-hicolor-icon-theme 

    shutter: wrap `XDG_DATA_DIRS` with `hicolor-icon-theme`
    @xeji
    xeji committed May 4, 2018
    Configuration menu
    Copy the full SHA
    4c8c314 View commit details
    Browse the repository at this point in the history