Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: 2.7.14 -> 2.7.15 (bugfix + security) #40005

Closed
wants to merge 3 commits into from
Closed

python: 2.7.14 -> 2.7.15 (bugfix + security) #40005

wants to merge 3 commits into from

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented May 5, 2018

Fixes CVE-2018-1000030, /cc #38993.

The ncurses patch no longer applied, and it appears the problems have been resolved upstream https://bugs.python.org/issue25720 python/cpython@6ba0b583d67

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

timokau and others added 2 commits April 26, 2018 16:45
@timokau
cpython: Fix upstream bugs NixOS#27177 and NixOS#25750
66f866a 
27177 was merged but not backported to 2.7.
There is currently an open PR for 25750.
@vcunat
python: 2.7.14 -> 2.7.15 (bugfix + security)
77b8311 
Fixes CVE-2018-1000030, /cc NixOS#38993.

The ncurses patch no longer applied, and it appears the problems have
been resolved upstream https://bugs.python.org/issue25720
python/cpython@6ba0b583d67
@vcunat vcunat added 6.topic: python 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels May 5, 2018
@vcunat vcunat requested a review from FRidh May 5, 2018 12:23
@vcunat
Copy link
Member Author

vcunat commented May 5, 2018

The security severity isn't too high, I guess. #38993 (comment) But I hope the patch update is safe enough to go to staging directly. I only tried compiling a few reverse dependencies.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: python

Partial log (click to expand)

gzipping man pages under /nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/share/man/
strip is /nix/store/pjfm07gclyzz5csx7kqdr4ji2gjzwizk-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/lib  /nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/bin
patching script interpreter paths in /nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15
/nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/42dfxz9b7g5fw5imvrkx4x2mh8sagk90-bash-4.4-p19/bin/sh"
/nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/42dfxz9b7g5fw5imvrkx4x2mh8sagk90-bash-4.4-p19/bin/sh"
/nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/42dfxz9b7g5fw5imvrkx4x2mh8sagk90-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15...
wrong ELF type
/nix/store/1gdlq877p5syba259c4zyrj9kc2iz26v-python-2.7.15

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: python

Partial log (click to expand)

gzipping man pages under /nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/share/man/
strip is /nix/store/gs3j0m07sw80657l5lkkrgzgi53nh5fi-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/lib  /nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/bin
patching script interpreter paths in /nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15
/nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/lib/python2.7/config/install-sh: interpreter directive changed from "/bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
/nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/lib/python2.7/config/makesetup: interpreter directive changed from " /bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
/nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15/lib/python2.7/ctypes/macholib/fetch_macholib: interpreter directive changed from "/bin/sh" to "/nix/store/ykdxb9bgcw9cryldfsz6yxjkyjayd9ka-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15...
wrong ELF type
/nix/store/zcmk97mzixqfqkkvnjd0dgd3xgbwn0l0-python-2.7.15

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: python

Partial log (click to expand)

cannot build derivation '/nix/store/9mbwbrvcqwmi69icq0pmxxl6ca0n1h7i-ICU-osx-10.10.5.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/kf6hkdiwawp8qsdcaiixv7skxkgnflkh-flex-2.6.4.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/mkbwkvkd0q05g2w41jyj3zccj5gb6awy-CF-osx-10.10.5.drv': 8 dependencies couldn't be built
cannot build derivation '/nix/store/mf6livdkx5gmb62qhr5ckvmaggxk9ky7-bootstrap_cmds-dev-tools-7.0.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/431rja6phca9kxlxd8d1ikn124qlqpir-python-2.7.15.drv': 15 dependencies couldn't be built
cannot build derivation '/nix/store/7qfpd74fdh714zyrn7g700jamxadqrsk-xnu-osx-10.11.6.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/jrn8vnhx64c4zwr9fnljgbyi920s6gfd-IOKit-osx-10.11.6.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/xcxl62hz5kb81rkd0ph7918255cydvwq-configd-osx-10.8.5.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/yjm6r3b66nkj4ki1r1vqm75kka4nbgf4-python-2.7.15.drv': 16 dependencies couldn't be built
error: build of '/nix/store/yjm6r3b66nkj4ki1r1vqm75kka4nbgf4-python-2.7.15.drv' failed

@vcunat vcunat mentioned this pull request May 6, 2018
Closed
8 tasks
@FRidh FRidh self-assigned this May 9, 2018
@FRidh
Copy link
Member

FRidh commented May 10, 2018

Pushed 59beaf7 to staging. Keeping this open until it lands in master.

Still need to backport to master.

@timokau
Copy link
Member

timokau commented May 12, 2018

59beaf7 doesn't include #39555 right? Is that on purpose?

@FRidh
Copy link
Member

FRidh commented May 13, 2018

@timokau yes, I first wanted to see whether the actual version bump would work out well, before adding your change. Considering staging is stuck there isn't really any hurry either.

@timokau
Copy link
Member

timokau commented May 28, 2018

Since 59beaf7 is in master now, I think this can be closed.

@vcunat vcunat closed this May 28, 2018
@vcunat vcunat deleted the p/python-2.7.15 branch May 28, 2018 16:37
@vcunat vcunat restored the p/python-2.7.15 branch August 12, 2018 08:20
@vcunat vcunat deleted the p/python-2.7.15 branch August 31, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
1.severity: security 2.status: merge conflict 6.topic: python 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vcunat @GrahamcOfBorg @FRidh @timokau