Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skhd: 0.0.12 -> 0.0.14 #40014

Merged
merged 1 commit into from May 6, 2018
Merged

skhd: 0.0.12 -> 0.0.14 #40014

merged 1 commit into from May 6, 2018

Conversation

periklis
Copy link
Contributor

@periklis periklis commented May 5, 2018

Motivation for this change

@LnL7

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
Copy link
Member

LnL7 commented May 6, 2018

@GrahamcOfBorg build skhd

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: skhd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: skhd

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: skhd

Partial log (click to expand)

installing
install flags: install SHELL=/nix/store/r8bx3qf1bpncb14i9gzma4vr089pc3pv-bash-4.4-p19/bin/bash BUILD_PATH=\$\(out\)/bin
rm -rf /nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14/bin
mkdir -p /nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14/bin
clang src/skhd.c -std=c99 -O3 -framework Carbon -o /nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14/bin/skhd
post-installation fixup
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14/bin
patching script interpreter paths in /nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14
/nix/store/jzvysvc3fkdbvw9al5i6ikisg2jcnndf-skhd-0.0.14

LnL7
LnL7 approved these changes May 6, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit e6d5558 into NixOS:master May 6, 2018
@periklis periklis deleted the darwin-skhd branch May 6, 2018 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@periklis @LnL7 @GrahamcOfBorg