Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plasma5: 5.12.4 -> 5.12.5 #40010

Merged
merged 1 commit into from May 14, 2018
Merged

plasma5: 5.12.4 -> 5.12.5 #40010

merged 1 commit into from May 14, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented May 5, 2018 •
edited

Motivation for this change

New bugfix release.

@ttuegel @adisbladis @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner May 5, 2018 18:39
@peterhoeg
Copy link
Member

Hopefully this solves systemsettings5 segfaulting...

@bkchr
Copy link
Contributor Author

bkchr commented May 7, 2018

I don't get any segfaults with systemsetting5, but I think it worked also with 5.12.4 for me.

@peterhoeg
Copy link
Member

On my laptop entering the Hardware / Display and Monitors / Displays causes a segfault while it's fine on the desktop. Let's see if this changes it.

@bkchr
Copy link
Contributor Author

bkchr commented May 8, 2018

Yeah, for me this page works.

@bkchr
Copy link
Contributor Author

bkchr commented May 13, 2018

@peterhoeg did you tried the changes?

@peterhoeg
Copy link
Member

peterhoeg commented May 14, 2018 via email

@ttuegel ttuegel merged commit 8a32c80 into NixOS:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bkchr @peterhoeg @ttuegel @GrahamcOfBorg