Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vscode backport #40011

Merged
merged 4 commits into from May 5, 2018
Merged

Vscode backport #40011

merged 4 commits into from May 5, 2018

Conversation

ambrop72
Copy link
Contributor

@ambrop72 ambrop72 commented May 5, 2018

Motivation for this change

Update VS Code in 18.03.

The commits are cherry-picked without conflicts, but I did the vscode part of 52893d5 manually to simplify future backports.

It works fine though I didn't test anything from vscode-extensions since I don't use anything from there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer matthewbauer merged commit 5f16ba8 into NixOS:release-18.03 May 5, 2018
@ambrop72 ambrop72 deleted the vscode-backport branch May 5, 2018 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants