Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add package: git-secrets #39990

Merged
merged 2 commits into from May 5, 2018
Merged

Add package: git-secrets #39990

merged 2 commits into from May 5, 2018

Conversation

bbarker
Copy link
Contributor

@bbarker bbarker commented May 4, 2018

Motivation for this change

This is a new package: git-secrets

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member

@GrahamcOfBorg build gitAndTools.git-secret

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitAndTools.git-secret

Partial log (click to expand)

these paths will be fetched (0.02 MiB download, 0.05 MiB unpacked):
  /nix/store/2x68qvnjzb5q58inxxdzxphi4gz2llxh-git-secret-0.2.3
copying path '/nix/store/2x68qvnjzb5q58inxxdzxphi4gz2llxh-git-secret-0.2.3' from 'https://cache.nixos.org'...
/nix/store/2x68qvnjzb5q58inxxdzxphi4gz2llxh-git-secret-0.2.3

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: gitAndTools.git-secret

Partial log (click to expand)

copying path '/nix/store/arwfi5k9q1bm2c460q2gaibyf3c9s5cj-perl-HTTP-Cookies-6.04' from 'https://cache.nixos.org'...
copying path '/nix/store/xvbvwkspgggr7wrbvbxdwcwiv5sb2ggl-perl-HTTP-Daemon-6.01' from 'https://cache.nixos.org'...
copying path '/nix/store/6142hgl43ccy6znsi15ivshpz9v5c8fn-perl-HTTP-Negotiate-6.01' from 'https://cache.nixos.org'...
copying path '/nix/store/w07ms0fn9ky0arf5s9abiavlpk1p4dmh-openssh-7.6p1' from 'https://cache.nixos.org'...
copying path '/nix/store/lcpynpbwq6x62vyx3svsh7s61nl3vlv2-perl-libwww-perl-6.33' from 'https://cache.nixos.org'...
copying path '/nix/store/kp70y58paiap3h9k6vx4wimj4klbba31-git-2.16.3' from 'https://cache.nixos.org'...
copying path '/nix/store/971127zyryzvg17fh87jksaxbi1z01vm-openldap-2.4.45' from 'https://cache.nixos.org'...
copying path '/nix/store/zj12ayyrpygbdnl2ddmfrirrzhyzj00h-gnupg-2.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/cw0rn24jq9486dyj4q1nb140b6vq34i7-git-secret-0.2.3' from 'https://cache.nixos.org'...
/nix/store/cw0rn24jq9486dyj4q1nb140b6vq34i7-git-secret-0.2.3

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitAndTools.git-secret

Partial log (click to expand)

copying path '/nix/store/5vxn0cg5z21xd69klmr5gmj7wp5a0gx1-openssl-1.0.2o-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/918z5cipw0ai9al7a1plic2dm1k8np07-perl-libwww-perl-6.33' from 'https://cache.nixos.org'...
copying path '/nix/store/pf16lx06p07zklkdra52p7b5akpd35qj-openssl-1.0.2o-dev' from 'https://cache.nixos.org'...
copying path '/nix/store/yzdf211rvx7hv3a5l2drzhk3n7vfc286-unbound-1.7.0-lib' from 'https://cache.nixos.org'...
copying path '/nix/store/xxf38k5vfmlmsc3wcx2hpdr6sy050zzw-gnutls-3.5.10' from 'https://cache.nixos.org'...
copying path '/nix/store/pcw45dsm5l10s84hkmlx1s9vr74ipv79-gnupg-2.2.6' from 'https://cache.nixos.org'...
copying path '/nix/store/p85m242dg1zd85ln3cg0agx0q1n0n6h0-clang-5.0.1' from 'https://cache.nixos.org'...
copying path '/nix/store/w7ppnmm21zmnn5a6y3hrqjpbk0r721gj-git-2.16.3' from 'https://cache.nixos.org'...
copying path '/nix/store/2sa7mw7iysj9s38alf3xvdm68d9lv3zq-git-secret-0.2.3' from 'https://cache.nixos.org'...
/nix/store/2sa7mw7iysj9s38alf3xvdm68d9lv3zq-git-secret-0.2.3

@matthewbauer matthewbauer merged commit 78a71c8 into NixOS:master May 5, 2018
rycee
rycee reviewed May 8, 2018
View reviewed changes
pkgs/applications/version-management/git-and-tools/git-secrets/default.nix

meta = {
description = "Prevents you from committing passwords and other sensitive information to a git repository";
homepage = https://github.com/awslabs/git-secretshttps://github.com/awslabs/git-secrets;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This homepage URL seems incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee rycee left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bbarker @matthewbauer @GrahamcOfBorg @rycee