Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liferea: 1.12.2 -> 1.12.3 #40008

Merged
merged 1 commit into from May 5, 2018
Merged

liferea: 1.12.2 -> 1.12.3 #40008

merged 1 commit into from May 5, 2018

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented May 5, 2018

Motivation for this change

New patch release. Changelog at https://github.com/lwindolf/liferea/releases/tag/v1.12.3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor

jtojnar commented May 5, 2018

@GrahamcOfBorg build liferea

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: liferea

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: liferea

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3
shrinking /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/bin/.liferea-wrapped
shrinking /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/lib/liferea/web-extension/liblifereawebextension.so
gzipping man pages under /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/lib  /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/bin
patching script interpreter paths in /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3
/nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/bin/.liferea-add-feed-wrapped: interpreter directive changed from "/bin/sh" to "/nix/store/xn5gv3lpfy91yvfy9b0i7klfcxh9xskz-bash-4.4-p19/bin/sh"
checking for references to /build in /nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3...
/nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3

@jtojnar
Copy link
Contributor

jtojnar commented May 5, 2018 •
edited

The GNOME Keyring does not seem to work:

(liferea:17662): libpeas-WARNING **: 21:17:32.549: Error importing plugin 'gnome-keyring':
Traceback (most recent call last):
  File "/nix/store/m9yn46ynzj03qdw74s1v65kfw0brmidc-python3-3.6.5/lib/python3.6/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 994, in _gcd_import
  File "<frozen importlib._bootstrap>", line 971, in _find_and_load
  File "<frozen importlib._bootstrap>", line 955, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 665, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 678, in exec_module
  File "<frozen importlib._bootstrap>", line 219, in _call_with_frames_removed
  File "/nix/store/y4r33whmzp5h48lf9zr5qy6sjkjdxj06-liferea-1.12.3/lib/liferea/plugins/gnome-keyring.py", line 26, in <module>
    gi.require_version('GnomeKeyring', '1.0')
  File "/nix/store/ciklk8cbki2wchyq5kb92rnw6j0ayy15-python3.6-pygobject-3.26.1/lib/python3.6/site-packages/gi/__init__.py", line 130, in require_version
    raise ValueError('Namespace %s not available' % namespace)
ValueError: Namespace GnomeKeyring not available

But we are going to remove libgnome-keyring, perhaps we should wait for lwindolf/liferea#436

@jonafato
Copy link
Contributor Author

jonafato commented May 5, 2018

@jtojnar I get that same exception in 1.12.2 (if I recall correctly, I first saw this when upgrading from 1.12.1 to 1.12.2). I can look into that here if you'd like, but it doesn't seem to be related to this version bump.

@jtojnar jtojnar merged commit d0110ec into NixOS:master May 5, 2018
@jonafato jonafato deleted the liferea-1.12.3 branch May 5, 2018 20:10
@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: liferea

Partial log (click to expand)

[1806/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/Notifications/NotificationPermissionRequestManager.cpp.o
[1807/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/WebCoreSupport/WebContextMenuClient.cpp.o
[1808/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/WebCoreSupport/WebNotificationClient.cpp.o
[1809/2153] Building C object Source/WebKit/CMakeFiles/WebKit.dir/__/__/DerivedSources/webkit2gtk/WebKitWaylandClientProtocol.c.o
[1810/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/UIProcess/Notifications/WebNotificationManagerProxy.cpp.o
[1811/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/WebPage/WebDocumentLoader.cpp.o
[1812/2153] Building CXX object Source/WebKit/CMakeFiles/WebKit.dir/WebProcess/WebPage/LayerTreeHost.cpp.o
building of '/nix/store/ff03n8fmxwia5j41ijrn7pawwapap6x7-webkitgtk-2.20.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/13dxwwgyryxz03iagz4j986czsix9yga-liferea-1.12.3.drv': 1 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/13dxwwgyryxz03iagz4j986czsix9yga-liferea-1.12.3.drv' failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jonafato @jtojnar @GrahamcOfBorg