yarn2nix error handling improvements #39992
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
package.json
files can specify local paths as dependencies, and yarn creates corresponding entries in the yarn.lock file for them. Currently yarn2nix errors when processing those entries, but still exits with a zero status. This means thatyarn2nix.mkYarnPackage
writes an incomplete and unparseable nix file to the store and then tries to read it, with an error likeerror: syntax error, unexpected $end, at /nix/store/76ml5lgvrc41b5c4y8jsy1iw8z50cw8s-yarn.nix:3081:6
.One way to reproduce:
I don't know what the policy around the yarn2nix version number is; sorry if I was wrong to bump it.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)