Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

platformio: add git to chroot so it is usable by platformio command #39998

Merged
merged 1 commit into from May 7, 2018
Merged

platformio: add git to chroot so it is usable by platformio command #39998

merged 1 commit into from May 7, 2018

Conversation

mogorman
Copy link
Contributor

@mogorman mogorman commented May 5, 2018 •
edited

Motivation for this change

platformio can pull down libraries and compiler toolchains via git if the command is visible in the chroot. Case in point the riscv toolchain only exists currently in git

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

dotlambda
dotlambda reviewed May 5, 2018
View reviewed changes
pkgs/development/arduino/platformio/chrootenv.nix Outdated
@@ -25,6 +25,7 @@ let
setuptools
pip
bottle
git
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

git is not in python.pkgs

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya i put in wrong place i repushed it correctly

@dotlambda
Copy link
Member

Did you actually test if this works? Is there a simple command I can execute to try it out?

@mogorman
Copy link
Contributor Author

mogorman commented May 5, 2018

@dotlambda i did after the correction a simple way would be to make a new project

mkdir testgit
cd testgit
pio init

and then add

[env:stable]
platform = https://github.com/platformio/platform-riscv.git
framework = freedom-e-sdk
board = freedom-e300-hifive1

to your platformio.ini and then

pio run

which will fetch down the build environment

@matthewbauer matthewbauer merged commit 96ef188 into NixOS:master May 7, 2018
@mogorman mogorman deleted the platformio branch May 7, 2018 06:55
@megheaiulian megheaiulian mentioned this pull request May 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mogorman @dotlambda @matthewbauer @GrahamcOfBorg