Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rocksdb: package binary tools #38998

Merged
merged 2 commits into from Apr 16, 2018
Merged

rocksdb: package binary tools #38998

merged 2 commits into from Apr 16, 2018

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

rocksdb includes some binaries that can be useful for debugging (sst_dump, ldb, rocksdb_dump, rocksdb_undump, blob_dump).
Add a bin output and install them there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

lukateras
lukateras reviewed Apr 16, 2018
View reviewed changes
pkgs/development/libraries/rocksdb/default.nix Outdated
@@ -1,4 +1,4 @@
{ stdenv
{ stdenv, lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use stdenv.lib instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yegortimoshenko I always write lib as a formal argument in my expressions; have we made a formal decision somewhere to prefer stdenv.lib over a separate lib argument?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've seen other reviewers ask that (@joachifm, @orivej), but I haven't seen a discussion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd wager that stdenv.lib vastly outnumbers passing lib separately (for package expressions). I'm unaware of any arguments beyond uniformity.

Whether it makes sense for stdenv to provide lib is debatable I suppose, but it does & is widely relied upon, so to me it makes more sense to just stick with convention for convention's sake.

@lukateras
Copy link
Member

@GrahamcOfBorg build rocksdb

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: rocksdb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: rocksdb

Partial log (click to expand)

stripping (with command strip and flags -S) in /nix/store/jmyv4gj7dc1z87wx6jyc7gm7gxd22qrh-rocksdb-5.10.3/lib
patching script interpreter paths in /nix/store/jmyv4gj7dc1z87wx6jyc7gm7gxd22qrh-rocksdb-5.10.3
/nix/store/jmyv4gj7dc1z87wx6jyc7gm7gxd22qrh-rocksdb-5.10.3/lib/librocksdb.5.10.3.dylib: fixing dylib
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/703jj81g66akx3agqdgiav8aflnwrwsj-rocksdb-5.10.3-static/lib
patching script interpreter paths in /nix/store/703jj81g66akx3agqdgiav8aflnwrwsj-rocksdb-5.10.3-static
strip is /nix/store/kdff2gim6417493yha769kh00n63lnrw-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/5gxaimn6jn4liz96a2pmvcidgpmaz1aq-rocksdb-5.10.3-bin/bin
patching script interpreter paths in /nix/store/5gxaimn6jn4liz96a2pmvcidgpmaz1aq-rocksdb-5.10.3-bin
/nix/store/a4ayqyya4frdxwfs8qn3z4pg13yn7vb3-rocksdb-5.10.3-dev

@lukateras lukateras merged commit 63a865c into NixOS:master Apr 16, 2018
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: rocksdb

Partial log (click to expand)

  /nix/store/rvzj3hx27zvg6lv12l3d2wrnjsibdw9g-rocksdb-5.10.3-dev
  /nix/store/sgwg51aawb92idyr6j8lzjjdg8mmd7ha-rocksdb-5.10.3-bin
  /nix/store/yxwycxs7jfh3xzbwwr50axa32ans0im4-rocksdb-5.10.3
copying path '/nix/store/2jzs75jhq8590i1vwc89dks1hzfpac7i-jemalloc-4.5.0' from 'https://cache.nixos.org'...
copying path '/nix/store/grffx916ray3d411wf9czx2y127jac6g-snappy-1.1.7' from 'https://cache.nixos.org'...
copying path '/nix/store/ic9qy3xcv4ahhrm9zd678ndwm0h53hhb-google-gflags-2.2.0' from 'https://cache.nixos.org'...
copying path '/nix/store/yxwycxs7jfh3xzbwwr50axa32ans0im4-rocksdb-5.10.3' from 'https://cache.nixos.org'...
copying path '/nix/store/sgwg51aawb92idyr6j8lzjjdg8mmd7ha-rocksdb-5.10.3-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/rvzj3hx27zvg6lv12l3d2wrnjsibdw9g-rocksdb-5.10.3-dev' from 'https://cache.nixos.org'...
/nix/store/rvzj3hx27zvg6lv12l3d2wrnjsibdw9g-rocksdb-5.10.3-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm joachifm left review comments

@cstrahan cstrahan cstrahan left review comments

@lukateras lukateras lukateras left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@yorickvP @lukateras @GrahamcOfBorg @joachifm @cstrahan