Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

borgbackup: add blake2 library to build inputs #38977

Merged
merged 2 commits into from Apr 16, 2018
Merged

borgbackup: add blake2 library to build inputs #38977

merged 2 commits into from Apr 16, 2018

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Apr 15, 2018 •
edited

Motivation for this change

Currently a vendored version of libb2 is used.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Moredread Moredread changed the title borgbackup: Add blake2 library to build inputs borgbackup: add blake2 library to build inputs Apr 15, 2018
@dotlambda
Copy link
Member

I added a commit that does the same for zstd.

@GrahamcOfBorg build borgbackup

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: borgbackup

Partial log (click to expand)

                 from /nix/store/i8py6fv0irvkl3s3kndqpw8szl1rzcic-python3.6-numpy-1.14.2/lib/python3.6/site-packages/numpy/core/include/numpy/arrayobject.h:4,
                 from memoryviewattrs.cpp:580:
/nix/store/i8py6fv0irvkl3s3kndqpw8szl1rzcic-python3.6-numpy-1.14.2/lib/python3.6/site-packages/numpy/core/include/numpy/npy_1_7_deprecated_api.h:15:2: warning: #warning "Using deprecated NumPy API, disable it by " "#defining NPY_NO_DEPRECATED_API NPY_1_7_API_VERSION" [-Wcpp]
 #warning "Using deprecated NumPy API, disable it by " \
  ^~~~~~~
acquired default
acquired Global_A
building of '/nix/store/l60jan1mgs2yd0lnkmsprzjapx4rynv9-python3.6-Cython-0.28.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/0qkg6akvym1mpvfhg6zisn03dm3havin-borgbackup-1.1.5.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/0qkg6akvym1mpvfhg6zisn03dm3havin-borgbackup-1.1.5.drv' failed

@Moredread
Copy link
Contributor Author

Moredread commented Apr 16, 2018 •
edited

@dotlambda does it really use it? I didn't see an option in the man page but didn't check in the code.

Edit: NVM, I looked it up in the source, it is mentioned in docs/changes.rst

@dotlambda
Copy link
Member

I didn't even bother looking at the docs, it's mentioned in setup.py.

@dotlambda dotlambda merged commit 0a9b436 into NixOS:master Apr 16, 2018
@Moredread Moredread deleted the borg/libb2 branch April 16, 2018 21:51
@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: borgbackup

Partial log (click to expand)

copying path '/nix/store/jh75rrglhvdjpm793zkc8jkzcpwwhajm-linux-pam-1.3.0' from 'https://cache.nixos.org'...
copying path '/nix/store/rvpzwqpsf13zxbvhjddyvxlxnr0d10gj-util-linux-2.31.1' from 'https://cache.nixos.org'...
copying path '/nix/store/3g0blkqhcbbcv1pyc3gq6zi3k8ikh86h-zstd-1.3.4' from 'https://cache.nixos.org'...
copying path '/nix/store/hpnx760s247labqc3nbn2kripk73p0ca-openssh-7.6p1' from 'https://cache.nixos.org'...
copying path '/nix/store/ac9hhhwcp0hzxbb3h5c025b1a5cai4bw-shadow-4.5' from 'https://cache.nixos.org'...
copying path '/nix/store/5rfnlsahjsncx7snxlf8qhkcq8yhpxbh-util-linux-2.31.1-bin' from 'https://cache.nixos.org'...
copying path '/nix/store/gnnjhnx36wxvay5vlls5kcr598l6qwnw-fuse-2.9.7' from 'https://cache.nixos.org'...
copying path '/nix/store/6c3f0lznm82ylaphxf3l4gh74mzkpxh6-python3.6-llfuse-1.3.3' from 'https://cache.nixos.org'...
copying path '/nix/store/52zkdp18h7pf0rl2wl14k3dw9i8szqiy-borgbackup-1.1.5' from 'https://cache.nixos.org'...
/nix/store/52zkdp18h7pf0rl2wl14k3dw9i8szqiy-borgbackup-1.1.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Moredread @dotlambda @GrahamcOfBorg