Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-zsh-completions: 0.3.9 -> 0.4.0 (fixes recently broken file completion) #39853

Merged
merged 1 commit into from May 2, 2018
Merged

nix-zsh-completions: 0.3.9 -> 0.4.0 (fixes recently broken file completion) #39853

merged 1 commit into from May 2, 2018

Conversation

hedning
Copy link
Contributor

@hedning hedning commented May 2, 2018 •
edited

Motivation for this change

Managed to introduce a regression last release that broke file completion.

Please backport to 18.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@hedning
nix-zsh-completions: 0.3.9 -> 0.4.0
f7a46b2 
Fix a nasty regression when completing eg. `-f`.
@matthewbauer matthewbauer merged commit 75e0556 into NixOS:master May 2, 2018
@hedning hedning deleted the nix-zsh-completions-0.4.0 branch March 1, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @matthewbauer @GrahamcOfBorg