Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux_mptcp: 0.93 -> 0.94 #39849

Merged
merged 1 commit into from Jun 29, 2018
Merged

linux_mptcp: 0.93 -> 0.94 #39849

merged 1 commit into from Jun 29, 2018

Conversation

teto
Copy link
Member

@teto teto commented May 2, 2018 •
edited

As mptcp is still evolving, it's good to keep at least the 2 last
versions for regression-testing.

Motivation for this change

I seem to have some bugs with 0.93 and wanted to test 0.94.

Things done

I've added mptcp0.94 while keeping 0.93. As the implementation still evolves fast, and in my experiments, I still rely on 0.93 I would like to keep both.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto
linux_mptcp: 0.93 -> 0.94
8585bd8 
As mptcp is still evolving, it's good to keep at least the 2 last
versions for regression-testing.
@adisbladis
Copy link
Member

As linux-mptcp-93.nix and linux-mptcp.nix are almost identical I'd like this to be refactored into a generic version.

@teto
Copy link
Member Author

teto commented May 2, 2018 •
edited

I feel like it's a bit vain though ? I dont'intend to maintain more than 2 kernels in parallel. As a maintainer I would rather see an overridable buildLinux function.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: linux_mptcp

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
cannot find section .dynamic
/nix/store/gzyi0n3ilxxvvycbvbn6il0pjqgkscjs-linux-4.14.24-mptcp_v0.94

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: linux_mptcp

Partial log (click to expand)

wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
wrong ELF type
/nix/store/c32j11awzj2xgjqrf1y6phr586pygnhk-linux-4.14.24-mptcp_v0.94

@matthewbauer
Copy link
Member

Is there a reason to keep the .93 version? Unless there is a breaking change we can just update it.

@teto
Copy link
Member Author

teto commented May 7, 2018

I feel it's relevant because the implementation evolves fast despite the limited userbase so bugs are not infrequent. Having at least 2 kernels makes it easier to compare the behaviors between versions.
I can maintain the 0.93 in my tree in case you don't share my concern.

@matthewbauer matthewbauer merged commit 45d120d into NixOS:master Jun 29, 2018
@teto teto deleted the mptcp94 branch May 13, 2020 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@teto @adisbladis @GrahamcOfBorg @matthewbauer