Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parser: fixed quoted heredoc followed by call #6048

Merged
merged 1 commit into from May 2, 2018
Merged

Parser: fixed quoted heredoc followed by call #6048

merged 1 commit into from May 2, 2018

Conversation

asterite
Copy link
Member

@asterite asterite commented May 1, 2018

Fixes #6030

@straight-shoota
Copy link
Member

The same thing with unquoted heredoc doesn't need a fix but you could add a spec for it. I don't think there is one.

@asterite
Copy link
Member Author

asterite commented May 1, 2018

@straight-shoota what would be an example code for that?

@straight-shoota
Copy link
Member

Just

it_parses "<<-EOF.x\n  foo\nEOF", Call.new("  foo".string_interpolation, "x")

@asterite
Copy link
Member Author

asterite commented May 1, 2018

@straight-shoota There are a few specs for that, not necessarily with a method call, but with a comma, and that's basically the same.

@asterite
Copy link
Member Author

asterite commented May 1, 2018

Nevermind, I added it...

@asterite asterite merged commit 53c4b1e into crystal-lang:master May 2, 2018
@RX14 RX14 added this to the Next milestone May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:bug topic:compiler:parser topic:compiler
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@asterite @straight-shoota @jhass @wooster0 @RX14