Compiler: define self variable inside types #6047
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wooster0
approved these changes
May 2, 2018
jhass
approved these changes
May 2, 2018
ysbaddaden
approved these changes
May 2, 2018
|
CI failed, I have to check why... |
|
This PR is wrong, other things needs to be done. The scope of vars should be different in each class/type, and different from the top-level scope (like in Ruby). Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5911
When
selfwas used inside a type, there wasn't really a variable representing it, we just assigned the type of thatselfnode to what it needed to be. But thatselfvar could later be needed to restrict its type in anis_a?or other constructs, so we now declare it.