Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

solc: 0.4.20 -> 0.4.23 #39852

Merged
merged 1 commit into from May 2, 2018
Merged

solc: 0.4.20 -> 0.4.23 #39852

merged 1 commit into from May 2, 2018

Conversation

akru
Copy link
Contributor

@akru akru commented May 2, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@akru akru mentioned this pull request May 2, 2018
Closed
8 tasks
@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: solc

Partial log (click to expand)

strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/kh7mn70s4k2yrfphypsbj92r69avyrsm-solc-0.4.23/lib  /nix/store/kh7mn70s4k2yrfphypsbj92r69avyrsm-solc-0.4.23/bin
patching script interpreter paths in /nix/store/kh7mn70s4k2yrfphypsbj92r69avyrsm-solc-0.4.23
head: write error: Broken pipe
checking for references to /build in /nix/store/kh7mn70s4k2yrfphypsbj92r69avyrsm-solc-0.4.23...
shrinking RPATHs of ELF executables and libraries in /nix/store/v5dhh84qrv7svlzk8vdvmvisy8b0h7dm-solc-0.4.23-dev
strip is /nix/store/gp7fylxwn18b7pl2c18ks89hsiaxyfvf-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/v5dhh84qrv7svlzk8vdvmvisy8b0h7dm-solc-0.4.23-dev
checking for references to /build in /nix/store/v5dhh84qrv7svlzk8vdvmvisy8b0h7dm-solc-0.4.23-dev...
/nix/store/kh7mn70s4k2yrfphypsbj92r69avyrsm-solc-0.4.23

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: solc

Partial log (click to expand)

shrinking /nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23/lib/libdevcore.so
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23/lib  /nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23/bin
patching script interpreter paths in /nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23
checking for references to /build in /nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23...
shrinking RPATHs of ELF executables and libraries in /nix/store/8n7y2gyig2x51dcbi7z3y10hpn3q0i2z-solc-0.4.23-dev
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/8n7y2gyig2x51dcbi7z3y10hpn3q0i2z-solc-0.4.23-dev
checking for references to /build in /nix/store/8n7y2gyig2x51dcbi7z3y10hpn3q0i2z-solc-0.4.23-dev...
/nix/store/0c1b47q8vksky8amwvad4n90jj5p79yh-solc-0.4.23

@joachifm joachifm merged commit 59ddcfa into NixOS:master May 2, 2018
@joachifm
Copy link
Contributor

joachifm commented May 2, 2018

Thank you

@akru akru deleted the solidity-shared-libs branch May 2, 2018 14:22
@asymmetric
Copy link
Contributor

@akru can you provide a usecase for this?

Is the patchset necessary to achieve this? It adds a non-zero maintenance burden every time any of the CMAKELists.txt files are updated.

@akru
Copy link
Contributor Author

akru commented Dec 23, 2019

@asymmetric I guess you can drop it if needed. It used in experimental flag of https://hackage.haskell.org/package/web3 but use case is rare.

@asymmetric
Copy link
Contributor

@akru I guess there are two options: if you want to maintain the patchset, we can move it behind an optional boolean attribute (buildSharedLibs ? false); otherwise, we can just remove it.

@akru
Copy link
Contributor Author

akru commented Dec 23, 2019

@asymmetric Let's remove it, if needed I'll make a fork.

@asymmetric asymmetric mentioned this pull request Dec 24, 2019
Merged
10 tasks
asymmetric added a commit to dapphub/nixpkgs that referenced this pull request Dec 26, 2019
@asymmetric
solc: 0.5.12 -> 0.5.15
4b45638 
Also removes patchset for shared library use, since usage of this
feature was rare and maintenance costly.
See NixOS#39852 (comment)
for a discussion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@akru @GrahamcOfBorg @joachifm @asymmetric