[WIP] Support for hackerthemes #3053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kwpolska
requested changes
Apr 19, 2018
CHANGES.txt
Outdated
| @@ -4,6 +4,7 @@ New in master | |||
| Features | |||
| -------- | |||
|
|
|||
| * Support hackerthemes.com themes and renamed bootswatch_theme command sub_theme (Issue #3049) | |||
There was a problem hiding this comment.
I’d prefer to spell it nikola subtheme
nikola/plugins/command/sub_theme.py
Outdated
| if fname == 'bootstrap.css': | ||
| url = 'https://raw.githubusercontent.com/HackerThemes/theme-machine/master/dist/{swatch}/css/bootstrap4-{swatch}.css'.format(swatch=swatch) | ||
| else: | ||
| url = 'https://raw.githubusercontent.com/HackerThemes/theme-machine/master/dist/{swatch}/css/bootstrap4-{swatch}.min.css'.format(swatch=swatch) |
There was a problem hiding this comment.
There are also some extras required, eg. for executive-suite one needs to add Google fonts to <head>:
<link href="https://fonts.googleapis.com/css?family=Merriweather|Oswald|Source+Sans+Pro" rel="stylesheet">There was a problem hiding this comment.
We could tweak that in the subtheme, I guess
Kwpolska
reviewed
Apr 25, 2018
nikola/plugins/command/subtheme.py
Outdated
| LOGGER.info("Downloading: " + url) | ||
| r = requests.get(url) | ||
| if r.status_code > 299: | ||
| LOGGER.error('Error {} getting {}', r.status_code, url) | ||
| exit(1) | ||
| return 1 | ||
| data = r.text | ||
| with open(os.path.join('themes', name, 'assets', 'css', fname), | ||
| 'wb+') as output: | ||
| output.write(data.encode('utf-8')) | ||
|
|
||
| with open(os.path.join('themes', name, 'parent'), 'wb+') as output: |
There was a problem hiding this comment.
BTW, we should probably output a new-style .theme file instead of parent
There was a problem hiding this comment.
good point. I'll do that.
Kwpolska
reviewed
May 2, 2018
| '%s.theme' % parent, themes) | ||
| cp = configparser.ConfigParser() | ||
| cp.read(parent_theme_data_path) | ||
| cp['Theme']['parent'] = parent |
There was a problem hiding this comment.
missing engine. family is unnecessary.
Kwpolska
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description