Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TODOs from class spec #5968

Merged
merged 1 commit into from Apr 19, 2018
Merged

Remove TODOs from class spec #5968

merged 1 commit into from Apr 19, 2018

Conversation

sdogruyol
Copy link
Member

SSIA

Sija
Sija reviewed Apr 19, 2018
View reviewed changes
spec/std/class_spec.cr Outdated
t = [A, B1, B2, C1]

it "<" do
(t[0] < t[0]).should eq(false)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd also change eq(false) to be_false, same goes for eq(true).

@asterite asterite merged commit 7b32e25 into crystal-lang:master Apr 19, 2018
@sdogruyol sdogruyol added this to the Next milestone Apr 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@asterite asterite asterite approved these changes

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:refactor topic:stdlib
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sdogruyol @Sija @asterite @straight-shoota @RX14