Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.vulkan: Fix dependency for vulkan #39163

Merged
merged 2 commits into from Apr 20, 2018
Merged

haskellPackages.vulkan: Fix dependency for vulkan #39163

merged 2 commits into from Apr 20, 2018

Conversation

expipiplus1
Copy link
Contributor

Note that the version of this package in nixpkgs currently (1.7.0.0) doesn't
compile. However the newest version (2.0.0.0) does, hopefully this gets bumped
soon :)

@expipiplus1 expipiplus1 requested a review from peti as a code owner April 19, 2018 17:15
@peti
Copy link
Member

peti commented Apr 19, 2018

Considering that this update is already in haskell-updates @ 69ede59f3d0a6de6dbd6771f522144944960d746, I think we can just wait a day or two until the branch gets merged into master. OK?

@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Apr 20, 2018 via email

@peti peti closed this Apr 20, 2018
@expipiplus1
Copy link
Contributor Author

@peti I think this can be merged now!

@peti
Copy link
Member

peti commented Apr 20, 2018

I don't understand what you mean???

@expipiplus1
Copy link
Contributor Author

I realize that my PR message is a little misleading, this PR changes configuration-common to allow the vulkan package to compile. A change which isn't in nixpkgs master at the moment.

@peti
Copy link
Member

peti commented Apr 20, 2018

Ah, now I see.

@peti peti reopened this Apr 20, 2018
@peti
Copy link
Member

peti commented Apr 20, 2018

@GrahamcOfBorg build haskellPackages.vulkan

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: haskellPackages.vulkan

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: haskellPackages.vulkan

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: haskellPackages.vulkan

Partial log (click to expand)

strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ix834xfv0hpjs315jpzqgdnbl2my23ci-vulkan-2.0.0.0/lib
patching script interpreter paths in /nix/store/ix834xfv0hpjs315jpzqgdnbl2my23ci-vulkan-2.0.0.0
checking for references to /build in /nix/store/ix834xfv0hpjs315jpzqgdnbl2my23ci-vulkan-2.0.0.0...
wrong ELF type
shrinking RPATHs of ELF executables and libraries in /nix/store/lxr6nqbl7y18hdiis4psgpf0s3vpnr1s-vulkan-2.0.0.0-doc
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
patching script interpreter paths in /nix/store/lxr6nqbl7y18hdiis4psgpf0s3vpnr1s-vulkan-2.0.0.0-doc
checking for references to /build in /nix/store/lxr6nqbl7y18hdiis4psgpf0s3vpnr1s-vulkan-2.0.0.0-doc...
/nix/store/ix834xfv0hpjs315jpzqgdnbl2my23ci-vulkan-2.0.0.0

@peti peti merged commit b5fd3a0 into NixOS:master Apr 20, 2018
@expipiplus1
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@expipiplus1 @peti @GrahamcOfBorg