Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Gitter badge #5967

Merged
merged 2 commits into from Apr 20, 2018
Merged

Add Gitter badge #5967

merged 2 commits into from Apr 20, 2018

Conversation

j8r
Copy link
Contributor

@j8r j8r commented Apr 19, 2018

This pull request adds this gitter badge to the README.md:

Join the chat at https://gitter.im/crystal-lang/crystal

@Sija
Copy link
Contributor

Sija commented Apr 19, 2018 •
edited

Are utm_* url parameters needed for anything particular (aside of feeding Gitter's backend stats)? If not, I'd suggest to drop 'em.

@j8r
Copy link
Contributor Author

j8r commented Apr 19, 2018

This is the default parameters when a new badge is created.
I'm thankful to GitLab to bring us a nice free and now (mostly) open sourced chat.
If this non-sensitive data can help them to improve their product, I don't mind much.
We can indeed remove this paramaters if most of us really want to.

@Sija
Copy link
Contributor

Sija commented Apr 19, 2018

Well, sorry if I'll sound unthankful but bloated url looks just awful + has terrible UX (think copying it through other channels - you'd either need to edit it manually or you'll mess with Gitter's stats - since such click would not come from the badge itself anymore).

@j8r
Copy link
Contributor Author

j8r commented Apr 19, 2018

Agree @Sija , no parameters would be the best, as said in https://github.com/gitterHQ/readme-badger/issues/37

@bcardiff bcardiff merged commit ef528a5 into crystal-lang:master Apr 20, 2018
@RX14 RX14 added this to the Next milestone Apr 20, 2018
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
@j8r @chris-huxtable
Add Gitter badge (crystal-lang#5967)
9dc678f
@j8r j8r deleted the gitter_badge branch October 16, 2018 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:infrastructure
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@j8r @Sija @sdogruyol @wooster0 @bcardiff @RX14