Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary preinfo.cs class code and white space on each code. #1016

Closed
wants to merge 6 commits into from
Closed

Conversation

jeong760
Copy link
Contributor

@jeong760 jeong760 commented Apr 19, 2018

  • Removed unused Preinfo.cs class code from on /src/CoiniumServ/Daemon/Responses

  • Removed white space on each code

  • Modify or add a code to support a UNIT(Universal Coin)

    • Add a new PropertyConvertor.cs class on /srv/CoiniumServ/Daemon/Converters/PropertyConverter.cs

    • Add a following code on MininInfo.cs on /srv/CoiniumServ/Daemon/Responses

      • [JsonProperty("netmh/s")] // added to support unit and possibly some other coins
      • private double NetMHps { get; set; }
    • Modify a following code on src\CoiniumServ\Daemon\DaemonBase.cs

      • using CoiniumServ.Daemon.Converters;
      • // process response with converter. needed for all coin wallets which gives non-standard info.
        string jsonLC = PropertyConverter.DeserializeWithLowerCasePropertyNames(json).ToString();
        _logger.Verbose("rx: {0}", jsonLC.PrettifyJson());
        try
        {
        return JsonConvert.DeserializeObject<DaemonResponse>(jsonLC);
        }

    Specially thanks to @flyx2888 to modify and add a new class for UNIT coin.

Regards,
John Ahn

@bonesoul
Copy link
Owner

why are you removing end of line in source files? any reason for that?

 - Add a new PropertyConverter.cs class
 - Change a MiningInfo.cs and add a Net MH/s
 - Change a DaemonBase.cs

 Specially thanks to @flyx2888
@jeong760
Copy link
Contributor Author

@bonesoul just removed white space each end of code is nothing special. but it could give more better cost and performance.

@bonesoul
Copy link
Owner

it has nothing with cost / performance. please remove whitespace changes from this pr.

@jeong760 jeong760 closed this Apr 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants