Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: fix instance of "meta.maintainer" -> "meta.maintainers" #39160

Merged
merged 1 commit into from
Apr 19, 2018
Merged

tree-wide: fix instance of "meta.maintainer" -> "meta.maintainers" #39160

merged 1 commit into from
Apr 19, 2018
+8 −8

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 19, 2018

Encountered one of these when using check-meta, did a quick
search to find other instances.

unbreak eval, fixup incorrect meta attribute names.

(Most of this does not apply!)

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@dtzWill
tree-wide: fix instance of "meta.maintainer" -> "meta.maintainers"
4f27362 
Encountered one of these when using check-meta, did a quick
search to find other instances.
@dtzWill dtzWill requested a review from FRidh as a code owner April 19, 2018 15:44
@GrahamcOfBorg GrahamcOfBorg added 6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Apr 19, 2018
@FRidh FRidh merged commit 5a66aaf into NixOS:master Apr 19, 2018
@FRidh
Copy link
Member

FRidh commented Apr 19, 2018

Thanks!

@dtzWill dtzWill deleted the fix/meta-maintainer-singular branch April 19, 2018 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @FRidh @GrahamcOfBorg