installer: allow opting in / out to the daemon installer #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By passing --daemon or --no-daemon, the installer can be forced to select one or the other installation options, despite what the automatic detection can provide. This commit can be backported to 2.0-maintenance because it explicitly turns off the daemon installation for Linux under systemd.
Note: don't backport to 2.0-maintenance
shlevy
approved these changes
Apr 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By passing --daemon or --no-daemon, the installer can be forced to
select one or the other installation options, despite what the
automatic detection can provide.
I'm hoping that by merging this PR and this PR to the homepage we can bring back the multi-user installer for nix 2.0: NixOS/nixos-homepage#212
The first commit can be backported to 2.0-maintenance because it explicitly
turns off the daemon installation for Linux under systemd. The second commit turns the daemon on by default, and should not be backported.
Under my hope that this is okay, I've prepared a backport branch which includes a revert-of-the-revert, plus the first commit: https://github.com/NixOS/nix/compare/2.0-maintenance...grahamc:re-backport-multi-user-linux?expand=1