Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: Add symbol literals support equal sign = as last char #5969

Merged
merged 2 commits into from Apr 22, 2018
Merged

Compiler: Add symbol literals support equal sign = as last char #5969

merged 2 commits into from Apr 22, 2018

Conversation

straight-shoota
Copy link
Member

Fixes #5965

oprypin
oprypin requested changes Apr 19, 2018
View reviewed changes
Copy link
Member

@oprypin oprypin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs spec for :a==:a

@straight-shoota
Copy link
Member Author

@oprypin You mean like assert_syntax_error ":foo==", "unexpected token: ="?

@oprypin
Copy link
Member

oprypin commented Apr 19, 2018

Would be much better if it worked, but if you're gonna introduce a breaking change, make it explicit

@oprypin
Copy link
Member

oprypin commented Apr 19, 2018

And when I wrote :a==:a, I meant :a==:a, not :foo==

@straight-shoota
Copy link
Member Author

straight-shoota commented Apr 19, 2018 •
edited

Ah, sry, I didn't catch your drift.

That's probably the reason why this wasn't implemented before. And now I'm not even sure if it should change...

It the change is still welcome, I guess :a==:a should raise a syntax error because it is ambiguous.

@asterite
Copy link
Member

For = and ! we should "abort" (just use the plain identifier) if a = follows (I think this can be checked with peek)

oprypin
oprypin approved these changes Apr 21, 2018
View reviewed changes
spec/compiler/lexer/lexer_spec.cr Outdated
token.value.should eq ("a")
end

it "lexes symbol wfollowed by ==" do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo w

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RX14 RX14 added this to the Next milestone Apr 22, 2018
@RX14 RX14 merged commit d6de698 into crystal-lang:master Apr 22, 2018
@straight-shoota straight-shoota deleted the jm/fix/symbol-literal-equals branch April 22, 2018 19:28
@straight-shoota straight-shoota mentioned this pull request Apr 26, 2018
Merged
chris-huxtable pushed a commit to chris-huxtable/crystal that referenced this pull request Jun 6, 2018
@straight-shoota @chris-huxtable
Compiler: Add symbol literals support equal sign = as last char (cr…
59a1f7c 
…ystal-lang#5969)

* Compiler: Add symbol literals support equal sign `=` as last char

* fixup! Compiler: Add symbol literals support equal sign `=` as last char
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhass jhass jhass approved these changes

@asterite asterite asterite approved these changes

@oprypin oprypin oprypin approved these changes

@wooster0 wooster0 wooster0 approved these changes

Assignees
No one assigned
Labels
kind:feature topic:compiler
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@straight-shoota @oprypin @asterite @jhass @wooster0 @RX14