-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compiler: Add symbol literals support equal sign =
as last char
#5969
Compiler: Add symbol literals support equal sign =
as last char
#5969
Conversation
ecdd7a9
to
5403783
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs spec for :a==:a
@oprypin You mean like |
Would be much better if it worked, but if you're gonna introduce a breaking change, make it explicit |
And when I wrote |
Ah, sry, I didn't catch your drift. That's probably the reason why this wasn't implemented before. And now I'm not even sure if it should change...
|
For = and ! we should "abort" (just use the plain identifier) if a = follows (I think this can be checked with peek) |
spec/compiler/lexer/lexer_spec.cr
Outdated
token.value.should eq ("a") | ||
end | ||
|
||
it "lexes symbol wfollowed by ==" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo w
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
26ac7ed
to
182b7c2
Compare
…ystal-lang#5969) * Compiler: Add symbol literals support equal sign `=` as last char * fixup! Compiler: Add symbol literals support equal sign `=` as last char
Fixes #5965