Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bonzomatic: init at 2018-03-29 #39171

Merged
merged 2 commits into from Apr 24, 2018
Merged

bonzomatic: init at 2018-03-29 #39171

merged 2 commits into from Apr 24, 2018

Conversation

ilian
Copy link
Member

@ilian ilian commented Apr 19, 2018 •
edited

Motivation for this change

Adds Bonzomatic, a live-coding tool for writing 2D fragment/pixel shaders.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

I added the unfreeRedistributable license, as the upstream repo contains libbass.so which is only free for non-commercial use.

infinisil
infinisil approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested this locally, works without problems. It need a simple config.json file in the current working directory to get started though. Here's one:

{
  "window":{
    "width":1440,
    "height":900,
    "fullscreen":false
  },
  "font":{
    "file":"/nix/store/h17zrpn0zfgx0p65ic457kb9plwll3n0-nerdfonts-1.1.0/share/fonts/truetype/NerdFonts/Iosevka Nerd Font Complete.ttf",
  }
}

(I got the font path with fc-list)

@infinisil
Copy link
Member

@GrahamcOfBorg build bonzomatic

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: bonzomatic

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: bonzomatic

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnfree = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnfree = true; }
to ~/.config/nixpkgs/config.nix.

nlewo
nlewo requested changes Apr 24, 2018
View reviewed changes
pkgs/applications/editors/bonzomatic/default.nix Outdated
let
name = "bonzomatic";
in stdenv.mkDerivation {
inherit name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a version in this package (the version is used by nix-env to upgarde). Something such as:

name = "${pname}-${version}"
pname = "bonzomatic";
version = "2018-03-29";

pkgs/applications/editors/bonzomatic/default.nix Outdated
{ stdenv, makeWrapper, fetchFromGitHub, cmake, alsaLib, mesa_glu, libXcursor, libXinerama, libXrandr, xorgserver }:

let
name = "bonzomatic";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By using a recursive attribute set as derivation argument, this is not required. You can see the rec keyword.

@nlewo
Copy link
Member

nlewo commented Apr 24, 2018

It would be nice to provide a default configuration file since it is not trivial to create it. This would be useful for reviewers to test future updates. This could be addressed in another PR.
Thanks.

@nlewo nlewo merged commit 18c6c49 into NixOS:master Apr 24, 2018
@oxzi oxzi mentioned this pull request Apr 5, 2021
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ilian @infinisil @GrahamcOfBorg @nlewo