Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing arguments to the Nix installer #212

Merged
merged 1 commit into from Apr 19, 2018

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Apr 19, 2018

This PR will allow users to pass arguments to he installer and have them be passed to the actual installer.

Example:

$ cat test.sh 
#!/bin/sh
{
echo "$@"
}

$ cat test.sh | sh -s hi eelco
hi eelco

Then, the interior installer can learn --no-daemon and --daemon, forcing on or off the switch to the daemon installer, overriding any detection done. The nix 2.0-maintenance can then receive the patches but default to single-user on Linux, but users can override it.

I'm hoping that by merging this PR and a subsequent PR to Nix we can bring back the multi-user installer for Linux 2.0.

@edolstra edolstra merged commit 0b4d635 into NixOS:master Apr 19, 2018
@grahamc grahamc deleted the args-to-the-installer branch April 19, 2018 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants