Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colord: fix ColorManager.conf installation path #39395

Closed
wants to merge 1 commit into from

Conversation

acowley
Copy link
Contributor

@acowley acowley commented Apr 24, 2018

This was fixed for colord-1.4.1 in this PR
fabc930

But the fix was lost in the upgrade to 1.4.2. Without this fix, the
colord.service crashes, and features like gnome-3's Night Light no
longer work.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

ping @jtojnar

This was fixed for colord-1.4.1 in this PR
NixOS@fabc930

But the fix was lost in the upgrade to 1.4.2. Without this fix, the
`colord.service` crashes, and features like gnome-3's Night Light no
longer work.
@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2018

This was fixed in #37994

@jtojnar jtojnar closed this Apr 24, 2018
@acowley
Copy link
Contributor Author

acowley commented Apr 24, 2018

Hm. Okay, thanks for the pointer. Color management does not work for me without this patch as the service crashes immediately. I will look into other explanations as time permits.

@jtojnar
Copy link
Contributor

jtojnar commented Apr 24, 2018

What revision of nixpkgs do you use? Night Light works for me on nixos-unstable.

@acowley acowley deleted the colord-conf branch January 27, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants