Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ecl_16_1_2: Adopt upstream error handling patch #39380

Merged
merged 1 commit into from Apr 23, 2018
Merged

ecl_16_1_2: Adopt upstream error handling patch #39380

merged 1 commit into from Apr 23, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 23, 2018 •
edited

Motivation for this change

Adopt an upstream fix for a infinite loop bug. This also disables threadSupport by default, since the package is only used by maxima-ecl anyways and that seems to work better (or at least the only package that depends on that, sage) without threading.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

Actually, EQL still works fine, not sure if it needs threads. Also, ECL works well as a standalone Lisp implementation.

I agree that it is strange to use Maxima with ECL except for Sage. Maybe override ecl thread support in maxima-ecl?

@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

This only overrides threadSupport for the ecl version that is pinned at 16_1_2, specially for maxima-ecl.

@7c6f434c
Copy link
Member

Point taken.

@7c6f434c 7c6f434c merged commit 7c35017 into NixOS:master Apr 23, 2018
@7c6f434c
Copy link
Member

(I slightly regret not being optimistic enough to believe that «asking ofborg if sage still builds» makes sense)

@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

What do you mean?

@timokau timokau deleted the ecl-error-handling branch April 23, 2018 20:06
@7c6f434c
Copy link
Member

Well, it could be useful to know if it still builds, but I know that it is a guaranteed timeout.

@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

Ah right. Well the current sage doesn't depend on this and the new version might build within the timeslot. Its tests will probably time out though, but not by a lot (its split in sagelib and sage, where sage just glues everything together and runs the testsuite).

@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

Off topic: Github suddenly seems to flip a coin to decide wether or not to notify me about things. I didn't get a notify for your reply for example. Is that only me?

@7c6f434c
Copy link
Member

Did you have the page open? It might JS-push the comment and decide there is no need to further notify you.

@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

I don't think so, but maybe. It happens all the time today. Hopefully not github getting too clever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @7c6f434c @GrahamcOfBorg