Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glpk: Add gmp support #39381

Merged
merged 1 commit into from Apr 24, 2018
Merged

glpk: Add gmp support #39381

merged 1 commit into from Apr 24, 2018

Conversation

timokau
Copy link
Member

@timokau timokau commented Apr 23, 2018 •
edited

Motivation for this change

Excerpt from glpk's INSTALL file:

This feature allows the exact simplex solver to use the GNU MP
bignum library. If it is disabled, the exact simplex solver uses the
GLPK bignum module, which provides the same functionality as GNU MP,
however, it is much less efficient.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@timokau timokau changed the title glpk: Add gmp support [WIP] glpk: Add gmp support Apr 23, 2018
@timokau
Copy link
Member Author

timokau commented Apr 23, 2018

For some reason nox-review fails because of octaveFull which fails because of qscintilla-qt4. I can't imagine that being caused by this PR, but I'll investigate.

@timokau timokau changed the title [WIP] glpk: Add gmp support glpk: Add gmp support Apr 23, 2018
@timokau
Copy link
Member Author

timokau commented Apr 23, 2018 •
edited

Okay qscintilla also fails on master (#37330), so not the fault of this PR.

@dotlambda
Copy link
Member

@GrahamcOfBorg build glpk

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: glpk

Partial log (click to expand)

/nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65
make[1]: Leaving directory '/build/glpk-4.65'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65
shrinking /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65/lib/libglpk.so.40.3.0
shrinking /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65/bin/glpsol
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65/lib  /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65/bin
patching script interpreter paths in /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65
checking for references to /build in /nix/store/gsh5qb0c6rlg32gcpvqd0w6clnj0x5ni-glpk-4.65...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: glpk

Partial log (click to expand)

make[1]: Leaving directory '/build/glpk-4.65'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65
shrinking /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65/bin/glpsol
shrinking /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65/lib/libglpk.so.40.3.0
strip is /nix/store/j7d4mr0ikv974ig7yzhknpsq288js4bs-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65/lib  /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65/bin
patching script interpreter paths in /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65
checking for references to /build in /nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65...
/nix/store/1r5p3l7zzck54sniry61c236n25n3idg-glpk-4.65

@dotlambda dotlambda merged commit a0a1e5e into NixOS:master Apr 24, 2018
@timokau timokau deleted the glpk-gmp branch April 24, 2018 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timokau @dotlambda @GrahamcOfBorg